From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: sre@kernel.org, ricardo@marliere.net, linux-pm@vger.kernel.org,
patches@lists.linux.dev, Nathan Chancellor <nathan@kernel.org>
Subject: Re: [PATCH] power: supply: core: Fix power_supply_init_attrs() stub
Date: Wed, 28 Feb 2024 23:08:53 +0100 [thread overview]
Message-ID: <170915813332.50142.14586523550606175263.b4-ty@collabora.com> (raw)
In-Reply-To: <20240227-fix-power_supply_init_attrs-stub-v1-1-43365e68d4b3@kernel.org>
On Tue, 27 Feb 2024 13:34:42 -0700, Nathan Chancellor wrote:
> When building without CONFIG_SYSFS, there is an error because of a
> recent refactoring that failed to update the stub of
> power_supply_init_attrs():
>
> drivers/power/supply/power_supply_core.c: In function 'power_supply_class_init':
> drivers/power/supply/power_supply_core.c:1630:9: error: too few arguments to function 'power_supply_init_attrs'
> 1630 | power_supply_init_attrs();
> | ^~~~~~~~~~~~~~~~~~~~~~~
> In file included from drivers/power/supply/power_supply_core.c:25:
> drivers/power/supply/power_supply.h:25:20: note: declared here
> 25 | static inline void power_supply_init_attrs(struct device_type *dev_type) {}
> | ^~~~~~~~~~~~~~~~~~~~~~~
>
> [...]
Applied, thanks!
[1/1] power: supply: core: Fix power_supply_init_attrs() stub
commit: b683d738c0a1c4c8fcf83fdf5eb4c6ce3d5130c6
Best regards,
--
Sebastian Reichel <sebastian.reichel@collabora.com>
prev parent reply other threads:[~2024-02-28 22:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 20:34 [PATCH] power: supply: core: Fix power_supply_init_attrs() stub Nathan Chancellor
2024-02-27 20:39 ` Ricardo B. Marliere
2024-02-27 21:49 ` Nathan Chancellor
2024-02-28 1:31 ` Ricardo B. Marliere
2024-02-28 22:08 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170915813332.50142.14586523550606175263.b4-ty@collabora.com \
--to=sebastian.reichel@collabora.com \
--cc=linux-pm@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=patches@lists.linux.dev \
--cc=ricardo@marliere.net \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).