From: Helge Deller <deller@gmx.de>
To: Max Kellermann <max.kellermann@ionos.com>,
rostedt@goodmis.org, mhiramat@kernel.org, mark.rutland@arm.com,
James.Bottomley@HansenPartnership.com,
linux-trace-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] parisc/ftrace: add missing CONFIG_DYNAMIC_FTRACE check
Date: Fri, 16 Feb 2024 14:30:14 +0100 [thread overview]
Message-ID: <2eac5921-1bf4-4013-8002-f62a96d71829@gmx.de> (raw)
In-Reply-To: <20240211224314.169314-1-max.kellermann@ionos.com>
On 2/11/24 23:43, Max Kellermann wrote:
> Fixes a bug revealed by -Wmissing-prototypes when
> CONFIG_FUNCTION_GRAPH_TRACER is enabled but not CONFIG_DYNAMIC_FTRACE:
>
> arch/parisc/kernel/ftrace.c:82:5: error: no previous prototype for 'ftrace_enable_ftrace_graph_caller' [-Werror=missing-prototypes]
> 82 | int ftrace_enable_ftrace_graph_caller(void)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> arch/parisc/kernel/ftrace.c:88:5: error: no previous prototype for 'ftrace_disable_ftrace_graph_caller' [-Werror=missing-prototypes]
> 88 | int ftrace_disable_ftrace_graph_caller(void)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
applied to parisc git tree.
Thanks!
Helge
> ---
> arch/parisc/kernel/ftrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/parisc/kernel/ftrace.c b/arch/parisc/kernel/ftrace.c
> index d1defb9ede70..621a4b386ae4 100644
> --- a/arch/parisc/kernel/ftrace.c
> +++ b/arch/parisc/kernel/ftrace.c
> @@ -78,7 +78,7 @@ asmlinkage void notrace __hot ftrace_function_trampoline(unsigned long parent,
> #endif
> }
>
> -#ifdef CONFIG_FUNCTION_GRAPH_TRACER
> +#if defined(CONFIG_DYNAMIC_FTRACE) && defined(CONFIG_FUNCTION_GRAPH_TRACER)
> int ftrace_enable_ftrace_graph_caller(void)
> {
> static_key_enable(&ftrace_graph_enable.key);
prev parent reply other threads:[~2024-02-16 13:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 22:43 [PATCH] parisc/ftrace: add missing CONFIG_DYNAMIC_FTRACE check Max Kellermann
2024-02-16 13:30 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2eac5921-1bf4-4013-8002-f62a96d71829@gmx.de \
--to=deller@gmx.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=max.kellermann@ionos.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).