From: Masahiro Yamada <masahiroy@kernel.org>
To: linux-parisc@vger.kernel.org, Helge Deller <deller@gmx.de>,
John David Anglin <dave.anglin@bell.net>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>
Subject: [PATCH] linux/export: fix reference to exported functions for parisc64
Date: Wed, 6 Sep 2023 04:08:28 +0900 [thread overview]
Message-ID: <20230905190828.790400-1-masahiroy@kernel.org> (raw)
John David Anglin reported parisc has been broken since commit
ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost").
I checked the assembler output, and noticed function references are
prefixed with P%, so the situation in parisc64 is similar to ia64.
Fixes: ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost")
Reported-by: John David Anglin <dave.anglin@bell.net>
Closes: https://lore.kernel.org/linux-parisc/1901598a-e11d-f7dd-a5d9-9a69d06e6b6e@bell.net/T/#u
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
I just checked the assembler output, and I created this patch
based on my best guess. Only compile-tested.
I hope somebody will run-test this patch.
include/linux/export-internal.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/export-internal.h b/include/linux/export-internal.h
index 1c849db953a5..45fca09b2319 100644
--- a/include/linux/export-internal.h
+++ b/include/linux/export-internal.h
@@ -52,6 +52,8 @@
#ifdef CONFIG_IA64
#define KSYM_FUNC(name) @fptr(name)
+#elif defined(CONFIG_PARISC) && defined(CONFIG_64BIT)
+#define KSYM_FUNC(name) P%name
#else
#define KSYM_FUNC(name) name
#endif
--
2.39.2
next reply other threads:[~2023-09-05 20:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 19:08 Masahiro Yamada [this message]
2023-09-05 21:57 ` [PATCH] linux/export: fix reference to exported functions for parisc64 John David Anglin
2023-09-05 23:59 ` John David Anglin
2023-09-07 22:02 ` John David Anglin
2023-09-09 17:20 ` Masahiro Yamada
2023-09-09 19:20 ` Masahiro Yamada
2023-09-10 7:47 ` Masahiro Yamada
2023-09-10 21:30 ` John David Anglin
2023-09-12 13:01 ` Helge Deller
2023-09-12 13:20 ` John David Anglin
2023-09-12 14:05 ` Helge Deller
2023-09-12 14:53 ` John David Anglin
2023-09-12 21:53 ` John David Anglin
2023-09-13 17:58 ` John David Anglin
2023-09-13 21:22 ` John David Anglin
2023-09-13 23:45 ` Damien Le Moal
2023-09-14 0:29 ` John David Anglin
2023-09-14 0:45 ` Damien Le Moal
2023-09-14 1:15 ` Damien Le Moal
2023-09-14 2:24 ` Damien Le Moal
2023-09-14 15:07 ` John David Anglin
2023-09-14 21:59 ` Damien Le Moal
2023-09-05 22:14 ` John David Anglin
[not found] ` <1MbRk3-1q6Cp42Bcv-00bwDk@mail.gmx.net>
2023-09-09 17:15 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230905190828.790400-1-masahiroy@kernel.org \
--to=masahiroy@kernel.org \
--cc=dave.anglin@bell.net \
--cc=deller@gmx.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).