From: Helge Deller <deller@gmx.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] parisc: Strip upper 32 bit of sum in csum_ipv6_magic for 64-bit builds
Date: Tue, 27 Feb 2024 22:43:09 +0100 [thread overview]
Message-ID: <00ea2941-0289-440b-8281-84d283d796b3@gmx.de> (raw)
In-Reply-To: <20240227203351.3445929-1-linux@roeck-us.net>
On 2/27/24 21:33, Guenter Roeck wrote:
> IPv6 checksum tests with unaligned addresses on 64-bit builds result
> in unexpected failures.
>
> Expected expected == csum_result, but
> expected == 46591 (0xb5ff)
> csum_result == 46381 (0xb52d)
> with alignment offset 1
>
> Oddly enough, the problem disappeared after adding test code into
> the beginning of csum_ipv6_magic().
>
> As it turns out, the 'sum' parameter of csum_ipv6_magic() is declared as
> __wsum, which is a 32-bit variable. However, it is treated as 64-bit
> variable in the 64-bit assembler code. Tests showed that the upper 32 bit
> of the register used to pass the variable are _not_ cleared when entering
> the function. This can result in checksum calculation errors.
>
> Clearing the upper 32 bit of 'sum' as first operation in the assembler
> code fixes the problem.
>
> Acked-by: Helge Deller <deller@gmx.de>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
applied.
Thanks!
Helge
> ---
> v2: Updated subject, clarified that the problem only affects 64-bit builds,
> added Helge's Acked-by: tag.
>
> arch/parisc/include/asm/checksum.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/parisc/include/asm/checksum.h b/arch/parisc/include/asm/checksum.h
> index c949aa20fa16..2aceebcd695c 100644
> --- a/arch/parisc/include/asm/checksum.h
> +++ b/arch/parisc/include/asm/checksum.h
> @@ -126,6 +126,7 @@ static __inline__ __sum16 csum_ipv6_magic(const struct in6_addr *saddr,
> ** Try to keep 4 registers with "live" values ahead of the ALU.
> */
>
> +" depdi 0, 31, 32, %0\n"/* clear upper half of incoming checksum */
> " ldd,ma 8(%1), %4\n" /* get 1st saddr word */
> " ldd,ma 8(%2), %5\n" /* get 1st daddr word */
> " add %4, %0, %0\n"
prev parent reply other threads:[~2024-02-27 21:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 20:33 [PATCH v2] parisc: Strip upper 32 bit of sum in csum_ipv6_magic for 64-bit builds Guenter Roeck
2024-02-27 21:43 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00ea2941-0289-440b-8281-84d283d796b3@gmx.de \
--to=deller@gmx.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).