From: "Neil Armstrong" <narmstrong@baylibre.com>
To: Sungbo Eo <mans0n@gorani.run>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org, linux-oxnas@groups.io,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: oxnas: Fix clear-mask property
Date: Sun, 22 Mar 2020 14:05:22 +0100 [thread overview]
Message-ID: <ca1a1cdc-6c20-bd2c-d1ea-edd6610f68a4@baylibre.com> (raw)
In-Reply-To: <20200321143653.2412823-1-mans0n@gorani.run>
Hi,
Le 21/03/2020 à 15:36, Sungbo Eo a écrit :
> Disable all rps-irq interrupts during driver initialization to prevent
> an accidental interrupt on GIC.
>
> Fixes: 84316f4ef141 ("ARM: boot: dts: Add Oxford Semiconductor OX810SE dtsi")
> Fixes: 38d4a53733f5 ("ARM: dts: Add support for OX820 and Pogoplug V3")
> Signed-off-by: Sungbo Eo <mans0n@gorani.run>
> ---
> arch/arm/boot/dts/ox810se.dtsi | 4 ++--
> arch/arm/boot/dts/ox820.dtsi | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ox810se.dtsi b/arch/arm/boot/dts/ox810se.dtsi
> index 9f6c2b660ed3..0755e5864c4a 100644
> --- a/arch/arm/boot/dts/ox810se.dtsi
> +++ b/arch/arm/boot/dts/ox810se.dtsi
> @@ -323,8 +323,8 @@ intc: interrupt-controller@0 {
> interrupt-controller;
> reg = <0 0x200>;
> #interrupt-cells = <1>;
> - valid-mask = <0xFFFFFFFF>;
> - clear-mask = <0>;
> + valid-mask = <0xffffffff>;
> + clear-mask = <0xffffffff>;
> };
>
> timer0: timer@200 {
> diff --git a/arch/arm/boot/dts/ox820.dtsi b/arch/arm/boot/dts/ox820.dtsi
> index c9b327732063..90846a7655b4 100644
> --- a/arch/arm/boot/dts/ox820.dtsi
> +++ b/arch/arm/boot/dts/ox820.dtsi
> @@ -240,8 +240,8 @@ intc: interrupt-controller@0 {
> reg = <0 0x200>;
> interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
> #interrupt-cells = <1>;
> - valid-mask = <0xFFFFFFFF>;
> - clear-mask = <0>;
> + valid-mask = <0xffffffff>;
> + clear-mask = <0xffffffff>;
> };
>
> timer0: timer@200 {
>
Thanks a lot for the patch,
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
I'll apply it asap and push it to arm-soc fixes.
Neil
prev parent reply other threads:[~2020-03-22 13:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-21 14:36 [PATCH] ARM: dts: oxnas: Fix clear-mask property Sungbo Eo
2020-03-22 13:05 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca1a1cdc-6c20-bd2c-d1ea-edd6610f68a4@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-oxnas@groups.io \
--cc=mans0n@gorani.run \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).