From: Marc Zyngier <maz@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Sungbo Eo <mans0n@gorani.run>,
linux-oxnas@groups.io, Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
Daniel Golle <daniel@makrotopia.org>
Subject: Re: [PATCH] irqchip/versatile-fpga: Apply clear-mask earlier
Date: Sun, 22 Mar 2020 11:51:09 +0000 [thread overview]
Message-ID: <b333772bbc3037c47060cf1af1fff3e8@kernel.org> (raw)
In-Reply-To: <CACRpkdYvoVF_q1Re_v_sJCYVDOhte0NpdU91UtYB2SpHH60-jg@mail.gmail.com>
On 2020-03-22 11:45, Linus Walleij wrote:
> On Sat, Mar 21, 2020 at 2:40 PM Sungbo Eo <mans0n@gorani.run> wrote:
>
>> Clear its own IRQs before the parent IRQ get enabled, so that the
>> remaining IRQs do not accidentally interrupt the parent IRQ
>> controller.
>>
>> This patch also fixes a reboot bug on OX820 SoC, where the remaining
>> rps-timer IRQ raises a GIC interrupt that is left pending. After that,
>> the rps-timer IRQ is cleared during driver initialization, and there's
>> no IRQ left in rps-irq when local_irq_enable() is called, which evokes
>> an error message "unexpected IRQ trap".
>>
>> Fixes: bdd272cbb97a ("irqchip: versatile FPGA: support cascaded
>> interrupts from DT")
>> Signed-off-by: Sungbo Eo <mans0n@gorani.run>
>> Cc: Neil Armstrong <narmstrong@baylibre.com>
>> Cc: Daniel Golle <daniel@makrotopia.org>
>
> Good catch!
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Marc: Cc stable?
Sure, I'll add that.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
prev parent reply other threads:[~2020-03-22 11:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-21 13:38 [PATCH] irqchip/versatile-fpga: Apply clear-mask earlier Sungbo Eo
2020-03-21 14:05 ` Marc Zyngier
2020-03-22 11:45 ` Linus Walleij
2020-03-22 11:51 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b333772bbc3037c47060cf1af1fff3e8@kernel.org \
--to=maz@kernel.org \
--cc=daniel@makrotopia.org \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-oxnas@groups.io \
--cc=mans0n@gorani.run \
--cc=narmstrong@baylibre.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).