From: "Neil Armstrong" <narmstrong@baylibre.com>
To: Ma Feng <mafeng.ma@huawei.com>, linux@armlinux.org.uk
Cc: linux-arm-kernel@lists.infradead.org, linux-oxnas@groups.io,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: oxnas: make ox820_boot_secondary static
Date: Tue, 12 May 2020 10:24:13 +0200 [thread overview]
Message-ID: <799e6df7-7698-f2a7-e8eb-fd491c1cad8f@baylibre.com> (raw)
In-Reply-To: <1589247973-29728-1-git-send-email-mafeng.ma@huawei.com>
On 12/05/2020 03:46, Ma Feng wrote:
> Fix sparse warning:
>
> arch/arm/mach-oxnas/platsmp.c:30:12: warning: symbol 'ox820_boot_secondary' was
> not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ma Feng <mafeng.ma@huawei.com>
> ---
> arch/arm/mach-oxnas/platsmp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-oxnas/platsmp.c b/arch/arm/mach-oxnas/platsmp.c
> index ab35275..f0a50b9 100644
> --- a/arch/arm/mach-oxnas/platsmp.c
> +++ b/arch/arm/mach-oxnas/platsmp.c
> @@ -27,7 +27,8 @@ static void __iomem *gic_cpu_ctrl;
> #define GIC_CPU_CTRL 0x00
> #define GIC_CPU_CTRL_ENABLE 1
>
> -int __init ox820_boot_secondary(unsigned int cpu, struct task_struct *idle)
> +static int __init ox820_boot_secondary(unsigned int cpu,
> + struct task_struct *idle)
> {
> /*
> * Write the address of secondary startup into the
> --
> 2.7.4
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
prev parent reply other threads:[~2020-05-12 8:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 1:46 [PATCH] ARM: oxnas: make ox820_boot_secondary static Ma Feng
2020-05-12 8:24 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=799e6df7-7698-f2a7-e8eb-fd491c1cad8f@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-oxnas@groups.io \
--cc=linux@armlinux.org.uk \
--cc=mafeng.ma@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).