From: "Neil Armstrong" <narmstrong@baylibre.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-oxnas@groups.io,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: rawnand: oxnas: Make use of the helper function devm_platform_ioremap_resource()
Date: Wed, 1 Sep 2021 10:14:28 +0200 [thread overview]
Message-ID: <61ab65d3-bf52-5701-95d2-476b8c2d719c@baylibre.com> (raw)
In-Reply-To: <20210901074207.9333-1-caihuoqing@baidu.com>
On 01/09/2021 09:42, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/mtd/nand/raw/oxnas_nand.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/oxnas_nand.c b/drivers/mtd/nand/raw/oxnas_nand.c
> index f44947043e5a..cd112d45e0b5 100644
> --- a/drivers/mtd/nand/raw/oxnas_nand.c
> +++ b/drivers/mtd/nand/raw/oxnas_nand.c
> @@ -79,7 +79,6 @@ static int oxnas_nand_probe(struct platform_device *pdev)
> struct oxnas_nand_ctrl *oxnas;
> struct nand_chip *chip;
> struct mtd_info *mtd;
> - struct resource *res;
> int count = 0;
> int err = 0;
> int i;
> @@ -92,8 +91,7 @@ static int oxnas_nand_probe(struct platform_device *pdev)
>
> nand_controller_init(&oxnas->base);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - oxnas->io_base = devm_ioremap_resource(&pdev->dev, res);
> + oxnas->io_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(oxnas->io_base))
> return PTR_ERR(oxnas->io_base);
>
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
parent reply other threads:[~2021-09-01 8:14 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210901074207.9333-1-caihuoqing@baidu.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61ab65d3-bf52-5701-95d2-476b8c2d719c@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=caihuoqing@baidu.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-oxnas@groups.io \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).