From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: "Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Vladimir Zapolskiy" <vz@mleia.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Vinod Koul" <vkoul@kernel.org>, "Chen-Yu Tsai" <wens@csie.org>,
"Samuel Holland" <samuel@sholland.org>,
"Nobuhiro Iwamatsu" <nobuhiro1.iwamatsu@toshiba.co.jp>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
linux-amlogic@lists.infradead.org, linux-oxnas@groups.io,
linux-sunxi@lists.linux.dev, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net-next 01/11] net: stmmac: Make stmmac_pltfr_remove() return void
Date: Sun, 02 Apr 2023 16:41:14 +0200 [thread overview]
Message-ID: <2674462.mvXUDI8C0e@jernej-laptop> (raw)
In-Reply-To: <20230402143025.2524443-2-u.kleine-koenig@pengutronix.de>
Dne nedelja, 02. april 2023 ob 16:30:15 CEST je Uwe Kleine-König napisal(a):
> The function returns zero unconditionally. Change it to return void instead
> which simplifies some callers as error handing becomes unnecessary.
>
> The function is also used for some drivers as remove callback. Switch these
> to the .remove_new() callback. For some others no error can happen in the
> remove callback now, convert them to .remove_new(), too.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c | 9 +++------
> drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 9 +++------
> drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-oxnas.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 5 ++---
> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c | 2 +-
For sunxi:
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
> drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c | 4 +---
> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 4 +---
> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.h | 2 +-
> 17 files changed, 22 insertions(+), 33 deletions(-)
next parent reply other threads:[~2023-04-02 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230402143025.2524443-1-u.kleine-koenig@pengutronix.de>
[not found] ` <20230402143025.2524443-2-u.kleine-koenig@pengutronix.de>
2023-04-02 14:41 ` Jernej Škrabec [this message]
2023-04-03 15:55 ` [PATCH net-next 01/11] net: stmmac: Make stmmac_pltfr_remove() return void Simon Horman
2023-04-03 20:39 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2674462.mvXUDI8C0e@jernej-laptop \
--to=jernej.skrabec@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bhupesh.sharma@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=joabreu@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=kuba@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-oxnas@groups.io \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vkoul@kernel.org \
--cc=vz@mleia.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).