From: Lizhe <sensor1010@163.com>
To: marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io,
linus.walleij@linaro.org, neil.armstrong@linaro.org,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
daniel@zonque.org, haojian.zhuang@gmail.com,
robert.jarzmik@free.fr
Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-oxnas@groups.io, linux-stm32@st-md-mailman.stormreply.com,
Lizhe <sensor1010@163.com>
Subject: [PATCH] dirvers/pinctrl.c : using pinctrl_dev->dev to obtain struct device * dev
Date: Mon, 8 May 2023 23:40:43 +0800 [thread overview]
Message-ID: <20230508154043.11859-1-sensor1010@163.com> (raw)
After the execution of the devm_pinctrl_register() function,
the member 'dev' in the 'pinctrl_dev' points to the
'struct device' structure. see pinctrl_init_controller().
Signed-off-by: Lizhe <sensor1010@163.com>
---
drivers/pinctrl/pinctrl-apple-gpio.c | 2 +-
drivers/pinctrl/pinctrl-oxnas.c | 12 ++++++------
drivers/pinctrl/pinctrl-pic32.c | 12 ++++++------
drivers/pinctrl/pinctrl-stmfx.c | 6 +++---
drivers/pinctrl/pxa/pinctrl-pxa2xx.c | 4 ++--
5 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-apple-gpio.c b/drivers/pinctrl/pinctrl-apple-gpio.c
index 3751c7de37aa..9dac920a3619 100644
--- a/drivers/pinctrl/pinctrl-apple-gpio.c
+++ b/drivers/pinctrl/pinctrl-apple-gpio.c
@@ -119,7 +119,7 @@ static int apple_gpio_dt_node_to_map(struct pinctrl_dev *pctldev,
ret = of_property_count_u32_elems(node, "pinmux");
if (ret <= 0) {
- dev_err(pctl->dev,
+ dev_err(pctldev->dev,
"missing or empty pinmux property in node %pOFn.\n",
node);
return ret ? ret : -EINVAL;
diff --git a/drivers/pinctrl/pinctrl-oxnas.c b/drivers/pinctrl/pinctrl-oxnas.c
index fb10a8473ebe..88b03bd9f4dc 100644
--- a/drivers/pinctrl/pinctrl-oxnas.c
+++ b/drivers/pinctrl/pinctrl-oxnas.c
@@ -596,7 +596,7 @@ static int oxnas_ox810se_pinmux_enable(struct pinctrl_dev *pctldev,
while (functions->name) {
if (!strcmp(functions->name, fname)) {
- dev_dbg(pctl->dev,
+ dev_dbg(pctldev->dev,
"setting function %s bank %d pin %d fct %d mask %x\n",
fname, pg->bank, pg->pin,
functions->fct, mask);
@@ -647,7 +647,7 @@ static int oxnas_ox820_pinmux_enable(struct pinctrl_dev *pctldev,
while (functions->name) {
if (!strcmp(functions->name, fname)) {
- dev_dbg(pctl->dev,
+ dev_dbg(pctldev->dev,
"setting function %s bank %d pin %d fct %d mask %x\n",
fname, pg->bank, pg->pin,
functions->fct, mask);
@@ -697,7 +697,7 @@ static int oxnas_ox810se_gpio_request_enable(struct pinctrl_dev *pctldev,
struct oxnas_gpio_bank *bank = gpiochip_get_data(range->gc);
u32 mask = BIT(offset - bank->gpio_chip.base);
- dev_dbg(pctl->dev, "requesting gpio %d in bank %d (id %d) with mask 0x%x\n",
+ dev_dbg(pctldev->dev, "requesting gpio %d in bank %d (id %d) with mask 0x%x\n",
offset, bank->gpio_chip.base, bank->id, mask);
regmap_write_bits(pctl->regmap,
@@ -909,7 +909,7 @@ static int oxnas_ox810se_pinconf_set(struct pinctrl_dev *pctldev,
u32 offset = pin - bank->gpio_chip.base;
u32 mask = BIT(offset);
- dev_dbg(pctl->dev, "setting pin %d bank %d mask 0x%x\n",
+ dev_dbg(pctldev->dev, "setting pin %d bank %d mask 0x%x\n",
pin, bank->gpio_chip.base, mask);
for (i = 0; i < num_configs; i++) {
@@ -946,7 +946,7 @@ static int oxnas_ox820_pinconf_set(struct pinctrl_dev *pctldev,
u32 offset = pin - bank->gpio_chip.base;
u32 mask = BIT(offset);
- dev_dbg(pctl->dev, "setting pin %d bank %d mask 0x%x\n",
+ dev_dbg(pctldev->dev, "setting pin %d bank %d mask 0x%x\n",
pin, bank->gpio_chip.base, mask);
for (i = 0; i < num_configs; i++) {
@@ -960,7 +960,7 @@ static int oxnas_ox820_pinconf_set(struct pinctrl_dev *pctldev,
mask, mask);
break;
default:
- dev_err(pctl->dev, "Property %u not supported\n",
+ dev_err(pctldev->dev, "Property %u not supported\n",
param);
return -ENOTSUPP;
}
diff --git a/drivers/pinctrl/pinctrl-pic32.c b/drivers/pinctrl/pinctrl-pic32.c
index dad05294fa72..bc98888acb7c 100644
--- a/drivers/pinctrl/pinctrl-pic32.c
+++ b/drivers/pinctrl/pinctrl-pic32.c
@@ -1937,23 +1937,23 @@ static int pic32_pinconf_set(struct pinctrl_dev *pctldev, unsigned pin,
switch (param) {
case PIN_CONFIG_BIAS_PULL_UP:
- dev_dbg(pctl->dev, " pullup\n");
+ dev_dbg(pctldev->dev, " pullup\n");
writel(mask, bank->reg_base +PIC32_SET(CNPU_REG));
break;
case PIN_CONFIG_BIAS_PULL_DOWN:
- dev_dbg(pctl->dev, " pulldown\n");
+ dev_dbg(pctl_dev->dev, " pulldown\n");
writel(mask, bank->reg_base + PIC32_SET(CNPD_REG));
break;
case PIN_CONFIG_MICROCHIP_DIGITAL:
- dev_dbg(pctl->dev, " digital\n");
+ dev_dbg(pctl_dev->dev, " digital\n");
writel(mask, bank->reg_base + PIC32_CLR(ANSEL_REG));
break;
case PIN_CONFIG_MICROCHIP_ANALOG:
- dev_dbg(pctl->dev, " analog\n");
+ dev_dbg(pctldev->dev, " analog\n");
writel(mask, bank->reg_base + PIC32_SET(ANSEL_REG));
break;
case PIN_CONFIG_DRIVE_OPEN_DRAIN:
- dev_dbg(pctl->dev, " opendrain\n");
+ dev_dbg(pctldev->dev, " opendrain\n");
writel(mask, bank->reg_base + PIC32_SET(ODCU_REG));
break;
case PIN_CONFIG_INPUT_ENABLE:
@@ -1964,7 +1964,7 @@ static int pic32_pinconf_set(struct pinctrl_dev *pctldev, unsigned pin,
offset, arg);
break;
default:
- dev_err(pctl->dev, "Property %u not supported\n",
+ dev_err(pctldev->dev, "Property %u not supported\n",
param);
return -ENOTSUPP;
}
diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c
index ab23d7ac3107..396996201856 100644
--- a/drivers/pinctrl/pinctrl-stmfx.c
+++ b/drivers/pinctrl/pinctrl-stmfx.c
@@ -711,7 +711,7 @@ static int stmfx_pinctrl_probe(struct platform_device *pdev)
ret = devm_gpiochip_add_data(pctl->dev, &pctl->gpio_chip, pctl);
if (ret) {
- dev_err(pctl->dev, "gpio_chip registration failed\n");
+ dev_err(pctldev->dev, "gpio_chip registration failed\n");
return ret;
}
@@ -724,11 +724,11 @@ static int stmfx_pinctrl_probe(struct platform_device *pdev)
IRQF_ONESHOT,
dev_name(pctl->dev), pctl);
if (ret) {
- dev_err(pctl->dev, "cannot request irq%d\n", irq);
+ dev_err(pctldev->dev, "cannot request irq%d\n", irq);
return ret;
}
- dev_info(pctl->dev,
+ dev_info(pctldev->dev,
"%ld GPIOs available\n", hweight_long(pctl->gpio_valid_mask));
return 0;
diff --git a/drivers/pinctrl/pxa/pinctrl-pxa2xx.c b/drivers/pinctrl/pxa/pinctrl-pxa2xx.c
index d2568dab8c78..f997cc26f01f 100644
--- a/drivers/pinctrl/pxa/pinctrl-pxa2xx.c
+++ b/drivers/pinctrl/pxa/pinctrl-pxa2xx.c
@@ -91,7 +91,7 @@ static int pxa2xx_pmx_gpio_set_direction(struct pinctrl_dev *pctldev,
void __iomem *gpdr;
gpdr = pctl->base_gpdr[pin / 32];
- dev_dbg(pctl->dev, "set_direction(pin=%d): dir=%d\n",
+ dev_dbg(pctldev->dev, "set_direction(pin=%d): dir=%d\n",
pin, !input);
spin_lock_irqsave(&pctl->lock, flags);
@@ -156,7 +156,7 @@ static int pxa2xx_pmx_set_mux(struct pinctrl_dev *pctldev, unsigned function,
gafr = pctl->base_gafr[pin / 16];
gpdr = pctl->base_gpdr[pin / 32];
shift = (pin % 16) << 1;
- dev_dbg(pctl->dev, "set_mux(pin=%d): af=%d dir=%d\n",
+ dev_dbg(pctldev->dev, "set_mux(pin=%d): af=%d dir=%d\n",
pin, df->muxval >> 1, df->muxval & 0x1);
spin_lock_irqsave(&pctl->lock, flags);
--
2.34.1
next reply other threads:[~2023-05-08 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 15:40 Lizhe [this message]
2023-05-08 21:19 ` [PATCH] dirvers/pinctrl.c : using pinctrl_dev->dev to obtain struct device * dev kernel test robot
2023-05-09 10:59 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230508154043.11859-1-sensor1010@163.com \
--to=sensor1010@163.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-oxnas@groups.io \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marcan@marcan.st \
--cc=mcoquelin.stm32@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=robert.jarzmik@free.fr \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).