From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Tony Lindgren <tony@atomide.com>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andy@kernel.org>
Cc: linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH] gpio: tps65219: don't use CONFIG_DEBUG_GPIO
Date: Wed, 27 Dec 2023 15:57:24 +0100 [thread overview]
Message-ID: <CAMRc=Mfu9tQNTYETtdmXyGtB1Gox7s_AcBwETVinZwR=LWdTLQ@mail.gmail.com> (raw)
In-Reply-To: <20231221185702.24685-1-brgl@bgdev.pl>
On Thu, Dec 21, 2023 at 7:57 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> CONFIG_DEBUG_GPIO should only be used to enable debug log messages and
> for core GPIOLIB debugging. Don't use it to control the execution of
> potentially buggy code. Just put it under an always-false #if.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> drivers/gpio/gpio-tps65219.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tps65219.c b/drivers/gpio/gpio-tps65219.c
> index 7b38aa360112..cd1f17041f8c 100644
> --- a/drivers/gpio/gpio-tps65219.c
> +++ b/drivers/gpio/gpio-tps65219.c
> @@ -96,16 +96,16 @@ static int tps65219_gpio_change_direction(struct gpio_chip *gc, unsigned int off
> * Below can be used for test purpose only.
> */
>
> - if (IS_ENABLED(CONFIG_DEBUG_GPIO)) {
> - int ret = regmap_update_bits(gpio->tps->regmap, TPS65219_REG_MFP_1_CONFIG,
> - TPS65219_GPIO0_DIR_MASK, direction);
> - if (ret) {
> - dev_err(dev,
> - "GPIO DEBUG enabled: Fail to change direction to %u for GPIO%d.\n",
> - direction, offset);
> - return ret;
> - }
> +#if 0
> + int ret = regmap_update_bits(gpio->tps->regmap, TPS65219_REG_MFP_1_CONFIG,
> + TPS65219_GPIO0_DIR_MASK, direction);
> + if (ret) {
> + dev_err(dev,
> + "GPIO DEBUG enabled: Fail to change direction to %u for GPIO%d.\n",
> + direction, offset);
> + return ret;
> }
> +#endif
>
> dev_err(dev,
> "GPIO%d direction set by NVM, change to %u failed, not allowed by specification\n",
> --
> 2.40.1
>
Patch applied.
Bart
prev parent reply other threads:[~2023-12-27 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 18:57 [PATCH] gpio: tps65219: don't use CONFIG_DEBUG_GPIO Bartosz Golaszewski
2023-12-21 19:06 ` Andy Shevchenko
2023-12-22 17:51 ` Linus Walleij
2023-12-27 14:57 ` Bartosz Golaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=Mfu9tQNTYETtdmXyGtB1Gox7s_AcBwETVinZwR=LWdTLQ@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=andy@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).