From: Denis Kirjanov <dkirjanov@suse.de>
To: Sinthu Raja <sinthu.raja@mistralsolutions.com>,
Siddharth Vadapalli <s-vadapalli@ti.com>,
Ravi Gunasekaran <r-gunasekaran@ti.com>,
Roger Quadros <rogerq@kernel.org>
Cc: linux-omap@vger.kernel.org, netdev@vger.kernel.org,
Sinthu Raja <sinthu.raja@ti.com>
Subject: Re: [PATCH V3] net: ethernet: ti: cpsw_new: enable mac_managed_pm to fix mdio
Date: Mon, 22 Jan 2024 11:57:37 +0300 [thread overview]
Message-ID: <8f031b17-9d86-42bf-b857-a7a46942a1cf@suse.de> (raw)
In-Reply-To: <20240122083414.6246-1-sinthu.raja@ti.com>
On 1/22/24 11:34, Sinthu Raja wrote:
> From: Sinthu Raja <sinthu.raja@ti.com>
>
> The below commit introduced a WARN when phy state is not in the states:
> PHY_HALTED, PHY_READY and PHY_UP.
> commit 744d23c71af3 ("net: phy: Warn about incorrect mdio_bus_phy_resume() state")
>
> When cpsw_new resumes, there have port in PHY_NOLINK state, so the below
> warning comes out. Set mac_managed_pm be true to tell mdio that the phy
> resume/suspend is managed by the mac, to fix the following warning:
>
> WARNING: CPU: 0 PID: 965 at drivers/net/phy/phy_device.c:326 mdio_bus_phy_resume+0x140/0x144
> CPU: 0 PID: 965 Comm: sh Tainted: G O 6.1.46-g247b2535b2 #1
> Hardware name: Generic AM33XX (Flattened Device Tree)
> unwind_backtrace from show_stack+0x18/0x1c
> show_stack from dump_stack_lvl+0x24/0x2c
> dump_stack_lvl from __warn+0x84/0x15c
> __warn from warn_slowpath_fmt+0x1a8/0x1c8
> warn_slowpath_fmt from mdio_bus_phy_resume+0x140/0x144
> mdio_bus_phy_resume from dpm_run_callback+0x3c/0x140
> dpm_run_callback from device_resume+0xb8/0x2b8
> device_resume from dpm_resume+0x144/0x314
> dpm_resume from dpm_resume_end+0x14/0x20
> dpm_resume_end from suspend_devices_and_enter+0xd0/0x924
> suspend_devices_and_enter from pm_suspend+0x2e0/0x33c
> pm_suspend from state_store+0x74/0xd0
> state_store from kernfs_fop_write_iter+0x104/0x1ec
> kernfs_fop_write_iter from vfs_write+0x1b8/0x358
> vfs_write from ksys_write+0x78/0xf8
> ksys_write from ret_fast_syscall+0x0/0x54
> Exception stack(0xe094dfa8 to 0xe094dff0)
> dfa0: 00000004 005c3fb8 00000001 005c3fb8 00000004 00000001
> dfc0: 00000004 005c3fb8 b6f6bba0 00000004 00000004 0059edb8 00000000 00000000
> dfe0: 00000004 bed918f0 b6f09bd3 b6e89a66
>
Please add "Fixes" tag
> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> ---
> drivers/net/ethernet/ti/cpsw_new.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/ti/cpsw_new.c b/drivers/net/ethernet/ti/cpsw_new.c
> index 498c50c6d1a7..087dcb67505a 100644
> --- a/drivers/net/ethernet/ti/cpsw_new.c
> +++ b/drivers/net/ethernet/ti/cpsw_new.c
> @@ -773,6 +773,9 @@ static void cpsw_slave_open(struct cpsw_slave *slave, struct cpsw_priv *priv)
> slave->slave_num);
> return;
> }
> +
> + phy->mac_managed_pm = true;
> +
> slave->phy = phy;
>
> phy_attached_info(slave->phy);
prev parent reply other threads:[~2024-01-22 8:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 8:34 [PATCH V3] net: ethernet: ti: cpsw_new: enable mac_managed_pm to fix mdio Sinthu Raja
2024-01-22 8:57 ` Denis Kirjanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f031b17-9d86-42bf-b857-a7a46942a1cf@suse.de \
--to=dkirjanov@suse.de \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=r-gunasekaran@ti.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=sinthu.raja@mistralsolutions.com \
--cc=sinthu.raja@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).