From: "Brock.Zheng" <yzheng@techyauld.com>
To: Roger Quadros <rogerq@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] memory: omap-gpmc: fixup wrongly hierarchy of the sub-devices
Date: Fri, 1 Mar 2024 07:52:30 +0800 [thread overview]
Message-ID: <6fftq2zlkpaf7xptyff6ky63cinr76ziyvdbm5jhj2apubr5vf@l4gvbdax3l2e> (raw)
On TI-AM335x，my FPGA under GPMC local-bus can not work on 6.x kernel.
GPMC <--> FPGA <--> sub-devices....
I found that the platform sub-devices is in wrongly organized
hierarchy. The grandchildren are now under the GPMC device
directly, not under it's father(FPGA).
Signed-off-by: Brock.Zheng <yzheng@techyauld.com>
---
drivers/memory/omap-gpmc.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index 80d038884207..1f2568e43086 100644
--- a/drivers/memory/omap-gpmc.c
+++ b/drivers/memory/omap-gpmc.c
@@ -2175,6 +2175,7 @@ static int gpmc_probe_generic_child(struct platform_device *pdev,
int ret, cs;
u32 val;
struct gpmc_device *gpmc = platform_get_drvdata(pdev);
+ struct platform_device *child_pdev = NULL;
if (of_property_read_u32(child, "reg", &cs) < 0) {
dev_err(&pdev->dev, "%pOF has no 'reg' property\n",
@@ -2330,11 +2331,12 @@ static int gpmc_probe_generic_child(struct platform_device *pdev,
no_timings:
/* create platform device, NULL on error or when disabled */
- if (!of_platform_device_create(child, NULL, &pdev->dev))
+ child_pdev = of_platform_device_create(child, NULL, &pdev->dev);
+ if (!child_pdev)
goto err_child_fail;
/* create children and other common bus children */
- if (of_platform_default_populate(child, NULL, &pdev->dev))
+ if (of_platform_default_populate(child, NULL, &child_pdev->dev))
goto err_child_fail;
return 0;
--
2.44.0
next reply other threads:[~2024-02-29 23:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 23:52 Brock.Zheng [this message]
2024-03-01 11:22 ` [PATCH] memory: omap-gpmc: fixup wrongly hierarchy of the sub-devices Roger Quadros
2024-03-01 12:38 ` Andreas Kemnade
2024-03-01 13:41 ` Roger Quadros
2024-03-01 23:57 ` [PATCH] memory/omap-gpmc: " Brock Zheng
2024-03-02 16:25 ` Krzysztof Kozlowski
[not found] ` <beacb55c-951b-4177-83ab-94fda44cd2b7@kernel.org>
2024-03-03 8:18 ` [PATCH] memory: omap-gpmc: " Brock Zheng
2024-03-05 9:55 ` Roger Quadros
2024-03-08 16:48 ` Krzysztof Kozlowski
2024-03-26 9:09 ` Krzysztof Kozlowski
2024-03-01 11:40 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fftq2zlkpaf7xptyff6ky63cinr76ziyvdbm5jhj2apubr5vf@l4gvbdax3l2e \
--to=yzheng@techyauld.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).