From: "Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com>
To: "neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Jessica Zhang <quic_jesszhan@quicinc.com>,
Sam Ravnborg <sam@ravnborg.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Helge Deller <deller@gmx.de>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v2] drm,fbdev: td043mtea1: Convert sprintf() family to sysfs_emit() family
Date: Tue, 19 Mar 2024 09:05:24 +0000 [thread overview]
Message-ID: <3b5c7af9-cebf-41e4-a492-15f33738c508@fujitsu.com> (raw)
In-Reply-To: <9907040c-7e25-4aa5-a4be-6f4820e335f1@linaro.org>
On 19/03/2024 16:07, Neil Armstrong wrote:
> Hi,
>
> On 19/03/2024 04:55, Li Zhijian wrote:
>> Per filesystems/sysfs.rst, show() should only use sysfs_emit()
>> or sysfs_emit_at() when formatting the value to be returned to user space.
>>
>> coccinelle complains that there are still a couple of functions that use
>> snprintf(). Convert them to sysfs_emit().
>>
>> sprintf() and scnprintf() will be converted as well if they have.
>>
>> Generally, this patch is generated by
>> make coccicheck M=<path/to/file> MODE=patch \
>> COCCI=scripts/coccinelle/api/device_attr_show.cocci
>>
>> No functional change intended
>
> Please split patches in 2, while the driver targets the same hw, they
> are not under the same subsystems.
Got it, i will do that soon.
Thanks
Zhijian
>
> Neil
>
>>
>> CC: Neil Armstrong <neil.armstrong@linaro.org>
>> CC: Jessica Zhang <quic_jesszhan@quicinc.com>
>> CC: Sam Ravnborg <sam@ravnborg.org>
>> CC: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> CC: Maxime Ripard <mripard@kernel.org>
>> CC: Thomas Zimmermann <tzimmermann@suse.de>
>> CC: David Airlie <airlied@gmail.com>
>> CC: Daniel Vetter <daniel@ffwll.ch>
>> CC: Helge Deller <deller@gmx.de>
>> CC: linux-omap@vger.kernel.org
>> CC: linux-fbdev@vger.kernel.org
>> CC: dri-devel@lists.freedesktop.org
>> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
>> ---
>> V2:
>> Fix missing '+' before '=' in drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
>>
>> This is a part of the work "Fix coccicheck device_attr_show warnings"[1]
>> Split them per subsystem so that the maintainer can review it easily
>> [1] https://lore.kernel.org/lkml/20240116041129.3937800-1-lizhijian@fujitsu.com/
>> ---
>> drivers/gpu/drm/panel/panel-tpo-td043mtea1.c | 13 ++++---------
>> .../omap2/omapfb/displays/panel-tpo-td043mtea1.c | 12 ++++--------
>> 2 files changed, 8 insertions(+), 17 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c b/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
>> index cf4609bb9b1d..0983fe47eb5a 100644
>> --- a/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
>> +++ b/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
>> @@ -242,16 +242,11 @@ static ssize_t gamma_show(struct device *dev, struct device_attribute *attr,
>> struct td043mtea1_panel *lcd = dev_get_drvdata(dev);
>> ssize_t len = 0;
>> unsigned int i;
>> - int ret;
>> - for (i = 0; i < ARRAY_SIZE(lcd->gamma); i++) {
>> - ret = snprintf(buf + len, PAGE_SIZE - len, "%u ",
>> - lcd->gamma[i]);
>> - if (ret < 0)
>> - return ret;
>> - len += ret;
>> - }
>> - buf[len - 1] = '\n';
>> + for (i = 0; i < ARRAY_SIZE(lcd->gamma); i++)
>> + len += sysfs_emit_at(buf, len, "%u ", lcd->gamma[i]);
>> + if (len)
>> + buf[len - 1] = '\n';
>> return len;
>> }
>> diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
>> index 477789cff8e0..3624452e1dd0 100644
>> --- a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
>> +++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
>> @@ -228,14 +228,10 @@ static ssize_t tpo_td043_gamma_show(struct device *dev,
>> int ret;
>> int i;
>> - for (i = 0; i < ARRAY_SIZE(ddata->gamma); i++) {
>> - ret = snprintf(buf + len, PAGE_SIZE - len, "%u ",
>> - ddata->gamma[i]);
>> - if (ret < 0)
>> - return ret;
>> - len += ret;
>> - }
>> - buf[len - 1] = '\n';
>> + for (i = 0; i < ARRAY_SIZE(ddata->gamma); i++)
>> + len += sysfs_emit_at(buf, len, "%u ", ddata->gamma[i]);
>> + if (len)
>> + buf[len - 1] = '\n';
>> return len;
>> }
>
prev parent reply other threads:[~2024-03-19 9:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 3:55 [PATCH v2] drm,fbdev: td043mtea1: Convert sprintf() family to sysfs_emit() family Li Zhijian
2024-03-19 8:07 ` Neil Armstrong
2024-03-19 9:05 ` Zhijian Li (Fujitsu) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b5c7af9-cebf-41e4-a492-15f33738c508@fujitsu.com \
--to=lizhijian@fujitsu.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).