From: Bjorn Helgaas <helgaas@kernel.org>
To: Peter Robinson <pbrobinson@gmail.com>
Cc: "Tom Joseph" <tjoseph@cadence.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] PCI: cadence: Fix TI J721E PCIe SoC dependencies
Date: Tue, 26 Dec 2023 17:59:47 -0600 [thread overview]
Message-ID: <20231226235947.GA1483922@bhelgaas> (raw)
In-Reply-To: <20231220113214.413632-1-pbrobinson@gmail.com>
On Wed, Dec 20, 2023 at 11:32:08AM +0000, Peter Robinson wrote:
> The J721E PCIe is hardware specific to the TI SoC parts
> so add a depenency on that so it's available for those
dependency
> SoC parts and for compile testing but not necessarily
> everyone who enables the Cadence PCIe controller.
Wrap to fill 75 columns.
The subject could possibly be more specific than "fix", e.g.,
PCI: cadence: Make TI J721E depend on ARCH_K3
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
> drivers/pci/controller/cadence/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/controller/cadence/Kconfig b/drivers/pci/controller/cadence/Kconfig
> index 291d12711363..1d5a70c9055e 100644
> --- a/drivers/pci/controller/cadence/Kconfig
> +++ b/drivers/pci/controller/cadence/Kconfig
> @@ -47,6 +47,7 @@ config PCI_J721E
>
> config PCI_J721E_HOST
> bool "TI J721E PCIe controller (host mode)"
> + depends on ARCH_K3 || COMPILE_TEST
> depends on OF
> select PCIE_CADENCE_HOST
> select PCI_J721E
> @@ -57,6 +58,7 @@ config PCI_J721E_HOST
>
> config PCI_J721E_EP
> bool "TI J721E PCIe controller (endpoint mode)"
> + depends on ARCH_K3 || COMPILE_TEST
> depends on OF
> depends on PCI_ENDPOINT
> select PCIE_CADENCE_EP
> --
> 2.43.0
>
prev parent reply other threads:[~2023-12-26 23:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 11:32 [PATCH] PCI: cadence: Fix TI J721E PCIe SoC dependencies Peter Robinson
2023-12-26 23:59 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231226235947.GA1483922@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=pbrobinson@gmail.com \
--cc=robh@kernel.org \
--cc=tjoseph@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).