From: Andreas Kemnade <andreas@kemnade.info>
To: Lee Jones <lee@kernel.org>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, bcousson@baylibre.com, tony@atomide.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 2/6] twl-core: add power off implementation for twl603x
Date: Sun, 3 Dec 2023 22:16:05 +0100 [thread overview]
Message-ID: <20231203221605.38496a8d@aktux> (raw)
In-Reply-To: <20231201104820.GC3259151@google.com>
On Fri, 1 Dec 2023 10:48:20 +0000
Lee Jones <lee@kernel.org> wrote:
> > + if (err) {
> > + pr_err("I2C error %d reading PHOENIX_DEV_ON\n", err);
>
> It would save an awful lot of lines and space if we could place these
> warnings/errors inside twl_i2c_read_u8().
Well, it is already in twl_i2c_read() ...
yes, we can save quite some lines.
Regards,
Andreas
next prev parent reply other threads:[~2023-12-03 21:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 22:19 [PATCH v2 0/6] mfd: twl: system-power-controller Andreas Kemnade
2023-11-27 22:19 ` [PATCH v2 1/6] dt-bindings: mfd: ti,twl: Document system-power-controller Andreas Kemnade
2023-11-27 22:19 ` [PATCH v2 2/6] twl-core: add power off implementation for twl603x Andreas Kemnade
2023-12-01 10:48 ` Lee Jones
2023-12-03 21:16 ` Andreas Kemnade [this message]
2023-11-27 22:19 ` [PATCH v2 3/6] ARM: dts: omap-embt2ws: system-power-controller for bt200 Andreas Kemnade
2023-11-27 22:19 ` [PATCH v2 4/6] ARM: dts: omap4-panda-common: Enable powering off the device Andreas Kemnade
2023-11-27 22:19 ` [PATCH v2 5/6] mfd: twl4030-power: accept standard property for power controller Andreas Kemnade
2023-11-27 22:19 ` [PATCH v2 6/6] ARM: dts: omap: gta04: standardize system-power-controller Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231203221605.38496a8d@aktux \
--to=andreas@kemnade.info \
--cc=bcousson@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).