From: Guixin Liu <kanie@linux.alibaba.com>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"hch@lst.de" <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH v8 0/1] Implement the NVMe reservation feature
Date: Tue, 12 Mar 2024 11:39:42 +0800 [thread overview]
Message-ID: <e9e9a7c1-44af-43b3-b2df-8290849eeb67@linux.alibaba.com> (raw)
In-Reply-To: <43565275-d71b-4c51-9a5c-b528e6387614@nvidia.com>
>> Sure, I do think we need at least one more reviewer.
>>
>> Plus, I don't think a target-side reservations maintainers entry is
>> justified here, it is a part of nvmet.
>> So please drop it from your next submission.
> Can you please send a next version with Sagi's comments ? also can you
> please send blktests if you have any so I can run some tests once I finish
> the review on next version ?
>
> -ck
Sure，but there is still a discussion going on in v7, I may need to change
the code, I will send a v9 after the discussion and with the blktests patch.
Best regards,
Guixin Liu
>
>
prev parent reply other threads:[~2024-03-12 3:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 3:12 [PATCH v8 0/1] Implement the NVMe reservation feature Guixin Liu
2024-02-29 3:12 ` [PATCH v8 1/1] nvmet: support " Guixin Liu
2024-03-05 2:32 ` [PATCH v8 0/1] Implement the NVMe " Guixin Liu
2024-03-07 8:18 ` Sagi Grimberg
2024-03-12 0:50 ` Chaitanya Kulkarni
2024-03-12 3:39 ` Guixin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9e9a7c1-44af-43b3-b2df-8290849eeb67@linux.alibaba.com \
--to=kanie@linux.alibaba.com \
--cc=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).