From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH blktests v1 0/3] add blkdev type environment variable
Date: Thu, 4 Apr 2024 11:07:50 +0000 [thread overview]
Message-ID: <b4agkxjt4wtcvxlv3wkl5potagg7ct5dd7wl6aqy523bzb53qo@bq6ebuvnxklx> (raw)
In-Reply-To: <j47jtsnraylush4xlxu6sng5frrawim5j2vjwt7zgei7jwi7ke@7ga6dd5sssur>
On Apr 04, 2024 / 10:29, Daniel Wagner wrote:
> On Thu, Apr 04, 2024 at 07:43:28AM +0000, Shinichiro Kawasaki wrote:
...
> > It sounds an interesting idea :) I prototyped the common code change based on
> > the idea and shared it on GitHub [*]. It introduces two new config arrays
> > NVMET_BLKDEV_TYPES and NVMET_TR_TYPES. When these two are set in config file as
> > follows,
> >
> > NVMET_BLKDEV_TYPES=(device file)
> > NVMET_TR_TYPES=(loop rdma tcp)
> >
> > it will run a single test case as follows. 2 x 3 = 6 times repeptitions.
> >
> > $ sudo ./check nvme/006
> > nvme/006(nvmet dev=device tr=loop)(create an NVMeOF target) [passed]
> > runtime 0.090s ... 0.091s
> > nvme/006(nvmet dev=device tr=rdma)(create an NVMeOF target) [passed]
> > runtime 0.310s ... 0.305s
> > nvme/006(nvmet dev=device tr=tcp)(create an NVMeOF target) [passed]
> > runtime 0.149s ... 0.153s
> > nvme/006(nvmet dev=file tr=loop)(create an NVMeOF target) [passed]
> > runtime 0.138s ... 0.135s
> > nvme/006(nvmet dev=file tr=rdma)(create an NVMeOF target) [passed]
> > runtime 0.300s ... 0.305s
> > nvme/006(nvmet dev=file tr=tcp)(create an NVMeOF target) [passed]
> > runtime 0.141s ... 0.147s
> >
> > I hope this meets your needs.
>
> Yes, this is very useful.
>
> > [*] https://github.com/kawasaki/blktests/tree/conditions
>
> I quickly looked into the changes. The only thing I'd say it looks a
> bit hard to extend if we have yet another variable. But maybe I'd make
> it too complex. I don't think we have to be too future proof here,
> because we can change this part without problems, it is all 'under the
> hood' and doesn't change the 'user interface'.
>
> Great stuff!
Okay, thanks for the positive comment. I will brush up the patches and post for
review. Let me have several days.
prev parent reply other threads:[~2024-04-04 11:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 10:03 [PATCH blktests v1 0/3] add blkdev type environment variable Daniel Wagner
2024-04-02 10:03 ` [PATCH blktests v1 1/3] nvme/rc: " Daniel Wagner
2024-04-02 10:03 ` [PATCH blktests v1 2/3] nvme/{007,009,011,013,015,020,024}: drop duplicate nvmet blkdev type tests Daniel Wagner
2024-04-02 10:03 ` [PATCH blktests v1 3/3] nvme/{021,022,025,026,027,028}: do not hard code target blkdev type Daniel Wagner
2024-04-02 10:10 ` [PATCH blktests v1 0/3] add blkdev type environment variable Daniel Wagner
2024-04-03 4:54 ` Shinichiro Kawasaki
2024-04-03 9:00 ` Daniel Wagner
2024-04-03 22:27 ` Chaitanya Kulkarni
2024-04-04 8:13 ` Daniel Wagner
2024-04-04 7:43 ` Shinichiro Kawasaki
2024-04-04 8:29 ` Daniel Wagner
2024-04-04 11:07 ` Shinichiro Kawasaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4agkxjt4wtcvxlv3wkl5potagg7ct5dd7wl6aqy523bzb53qo@bq6ebuvnxklx \
--to=shinichiro.kawasaki@wdc.com \
--cc=chaitanyak@nvidia.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).