From: Daniel Wagner <dwagner@suse.de>
To: Yi Zhang <yi.zhang@redhat.com>
Cc: "open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
Ming Lei <ming.lei@redhat.com>,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [bug report] blktests nvme/tcp nvme/014 failed due to Read/Flush timeout
Date: Mon, 22 Apr 2024 10:27:28 +0200 [thread overview]
Message-ID: <akehibl3xhwd5dt7euvljib5uyqkxk2efhka3kt6b6jcuyffmw@gpnfo6dikdzf> (raw)
In-Reply-To: <CAHj4cs_9XT6Ky4=LTy4SZ5AVfhAUec2k52b81-OKqzsDubobmw@mail.gmail.com>
On Mon, Apr 22, 2024 at 12:55:33PM +0800, Yi Zhang wrote:
> I found nvme/014 failed[1] on one of my servers, seems it was due to
> Read/Flush timeout during the test[2], I tried to add sync operation
> after the dd operation[3] and the failure can be fixed now and no
> timeout from dmesg, could anyone help check if it's one test issue or
> nvme/tcp stack issue, thanks.
From your log I'd say the sync command is just timing out too early. The
write operations are just too slow. Not really sure what the test is
suppose to test here. Should it test if the flush works or if the flush
is flushing any pending I/O? In the first case, the sync would be the
right fix. In the second case I suppose we would need to consider how
log it takes to flush pending I/Os and extend the timeout accordingly?
Thoughs?
prev parent reply other threads:[~2024-04-22 8:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 4:55 [bug report] blktests nvme/tcp nvme/014 failed due to Read/Flush timeout Yi Zhang
2024-04-22 8:27 ` Daniel Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akehibl3xhwd5dt7euvljib5uyqkxk2efhka3kt6b6jcuyffmw@gpnfo6dikdzf \
--to=dwagner@suse.de \
--cc=chaitanya.kulkarni@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).