From: Keith Busch <kbusch@kernel.org>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
gjoyce@linux.ibm.com, axboe@fb.com, chaitanyak@nvidia.com
Subject: Re: [PATCHv3] nvme: find numa distance only if controller has valid numa id
Date: Tue, 16 Apr 2024 10:44:37 -0600 [thread overview]
Message-ID: <Zh6q9dhnABofvGei@kbusch-mbp> (raw)
In-Reply-To: <20240416082102.914152-1-nilay@linux.ibm.com>
On Tue, Apr 16, 2024 at 01:49:23PM +0530, Nilay Shroff wrote:
> On system where native nvme multipath is configured and iopolicy
> is set to numa but the nvme controller numa node id is undefined
> or -1 (NUMA_NO_NODE) then avoid calculating node distance for
> finding optimal io path. In such case we may access numa distance
> table with invalid index and that may potentially refer to incorrect
> memory. So this patch ensures that if the nvme controller numa node
> id is -1 then instead of calculating node distance for finding optimal
> io path, we set the numa node distance of such controller to default 10
> (LOCAL_DISTANCE).
Thanks, applied to nvme-6.9.
prev parent reply other threads:[~2024-04-16 16:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 8:19 [PATCHv3] nvme: find numa distance only if controller has valid numa id Nilay Shroff
2024-04-16 9:07 ` Chaitanya Kulkarni
2024-04-16 9:43 ` Sagi Grimberg
2024-04-16 15:14 ` Christoph Hellwig
2024-04-16 16:44 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zh6q9dhnABofvGei@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=chaitanyak@nvidia.com \
--cc=gjoyce@linux.ibm.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).