From: Oliver Sang <oliver.sang@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: <oe-lkp@lists.linux.dev>, <lkp@intel.com>,
<linux-kernel@vger.kernel.org>, Keith Busch <kbusch@kernel.org>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
<linux-nvme@lists.infradead.org>, <ying.huang@intel.com>,
<feng.tang@intel.com>, <fengwei.yin@intel.com>,
<oliver.sang@intel.com>
Subject: Re: [linus:master] [nvme] 63dfa10043: fsmark.files_per_sec 6.4% improvement
Date: Tue, 19 Mar 2024 10:49:16 +0800 [thread overview]
Message-ID: <Zfj9LGMEjMEaN2DS@xsang-OptiPlex-9020> (raw)
In-Reply-To: <20240317203645.GB5975@lst.de>
hi, Christoph Hellwig,
On Sun, Mar 17, 2024 at 09:36:45PM +0100, Christoph Hellwig wrote:
> On Fri, Mar 15, 2024 at 04:21:13PM +0800, kernel test robot wrote:
> >
> >
> > Hello,
> >
> > kernel test robot noticed a 6.4% improvement of fsmark.files_per_sec on:
> >
> >
> > commit: 63dfa1004322d596417f23da43cdc43cf6298c71 ("nvme: move NVME_QUIRK_DEALLOCATE_ZEROES out of nvme_config_discard")
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> >
> > testcase: fsmark
> > test machine: 96 threads 2 sockets Intel(R) Xeon(R) Platinum 8260L CPU @ 2.40GHz (Cascade Lake) with 128G memory
> > parameters:
>
> That is kinda odd and unexpected. Is this system using one of the old
> Intel SSDs that this quirk is actually used for?
>
yeah, the nvme sdd on this system is quite old (DC P3608 serial):
https://www.intel.com/content/dam/www/public/us/en/documents/product-specifications/ssd-dc-p3608-spec.pdf
prev parent reply other threads:[~2024-03-19 2:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 8:21 [linus:master] [nvme] 63dfa10043: fsmark.files_per_sec 6.4% improvement kernel test robot
2024-03-17 20:36 ` Christoph Hellwig
2024-03-19 2:49 ` Oliver Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zfj9LGMEjMEaN2DS@xsang-OptiPlex-9020 \
--to=oliver.sang@intel.com \
--cc=feng.tang@intel.com \
--cc=fengwei.yin@intel.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=lkp@intel.com \
--cc=mgurtovoy@nvidia.com \
--cc=oe-lkp@lists.linux.dev \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).