From: Hannes Reinecke <hare@suse.de>
To: Sagi Grimberg <sagi@grimberg.me>,
Hannes Reinecke <hare@kernel.org>, Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org,
Redouane BOUFENGHOUR <redouane.boufenghour@shadow.tech>
Subject: Re: [PATCH 1/8] nvmet: add debugfs support
Date: Tue, 26 Mar 2024 12:55:55 +0100 [thread overview]
Message-ID: <9645b4b6-5cd2-4500-9e66-4fea027fd76c@suse.de> (raw)
In-Reply-To: <0e5f59ee-9ec0-4abe-bd57-ec3fe3d1b27e@grimberg.me>
On 3/23/24 21:25, Sagi Grimberg wrote:
>> +int nvmet_debugfs_subsys_setup(struct nvmet_subsys *subsys)
>> +{
>> + int ret = 0;
>> +
>> + subsys->debugfs_dir = debugfs_create_dir(subsys->subsysnqn,
>> + nvmet_debugfs);
>> + if (IS_ERR(subsys->debugfs_dir)) {
>> + ret = PTR_ERR(subsys->debugfs_dir);
>> + subsys->debugfs_dir = NULL;
>> + }
>> + return ret;
>> +}
>> +
>> +void nvmet_debugfs_subsys_free(struct nvmet_subsys *subsys)
>> +{
>> + debugfs_remove_recursive(subsys->debugfs_dir);
>> +}
>
> The subsys setup/free look trivial enough to just open-code
> in the call-sites.
>
> The rest looks fine to me.
Agreed for the 'free' call, the setup call has to stay as it's
referring to the static dentry 'nvmet_debugfs', which I'd like
to keep private to 'debugfs.c'.
Cheers,
Hannes
next prev parent reply other threads:[~2024-03-26 11:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 7:03 [PATCHv3 0/8] nvmet: debugfs support Hannes Reinecke
2024-03-22 7:03 ` [PATCH 1/8] nvmet: add " Hannes Reinecke
2024-03-23 20:25 ` Sagi Grimberg
2024-03-26 11:55 ` Hannes Reinecke [this message]
2024-03-25 18:18 ` Daniel Wagner
2024-03-25 19:22 ` Daniel Wagner
2024-03-25 22:39 ` Sagi Grimberg
2024-03-26 7:16 ` Daniel Wagner
2024-03-26 7:14 ` Hannes Reinecke
2024-03-26 7:22 ` Daniel Wagner
2024-03-22 7:03 ` [PATCH 2/8] nvmet: add 'host_traddr' callback for debugfs Hannes Reinecke
2024-03-23 20:27 ` Sagi Grimberg
2024-03-22 7:03 ` [PATCH 3/8] nvmet-tcp: implement host_traddr() Hannes Reinecke
2024-03-23 20:27 ` Sagi Grimberg
2024-03-22 7:03 ` [PATCH 4/8] nvmet-rdma: " Hannes Reinecke
2024-03-23 20:27 ` Sagi Grimberg
2024-03-22 7:03 ` [PATCH 5/8] nvmet-fc: " Hannes Reinecke
2024-03-22 7:03 ` [PATCH 6/8] nvme-fcloop: implement 'host_traddr' Hannes Reinecke
2024-03-22 7:03 ` [PATCH 7/8] lpfc_nvmet: " Hannes Reinecke
2024-03-22 7:03 ` [PATCH 8/8] nvmet: add debugfs support for queues Hannes Reinecke
2024-03-23 20:31 ` Sagi Grimberg
2024-03-25 7:25 ` Hannes Reinecke
2024-03-25 9:07 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9645b4b6-5cd2-4500-9e66-4fea027fd76c@suse.de \
--to=hare@suse.de \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=redouane.boufenghour@shadow.tech \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).