From: Sagi Grimberg <sagi@grimberg.me>
To: Hannes Reinecke <hare@suse.de>, Hannes Reinecke <hare@kernel.org>,
Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>,
James Smart <james.smart@broadcom.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCHv2 0/7] nvmet: debugfs support
Date: Thu, 21 Mar 2024 10:59:51 +0200 [thread overview]
Message-ID: <8bea2b12-e043-4599-93ee-0874ed27f87c@grimberg.me> (raw)
In-Reply-To: <a4ee4c4f-ac1e-4309-aacc-d25a14ad5091@suse.de>
On 21/03/2024 8:55, Hannes Reinecke wrote:
> On 3/21/24 00:07, Sagi Grimberg wrote:
>>
>>
>> On 20/03/2024 16:40, Hannes Reinecke wrote:
>>> Hi all,
>>>
>>> taking up the original patchset for nvmet debugfs
>>> I've improved upon that submission by modifying
>>> the layout:
>>>
>>> /dev/kernel/debug/nvmet
>>> <subsysnqn>
>>> ctrl<cntlid>
>>> port
>>> state
>>> hostnqn
>>> kato
>>> queue<qnum>
>>> host_traddr
>>
>> Why is host_traddr per queue?
>
> Blame TCP. We're having one connection per queue, and as such the
> peer address is a per-queue thingie.
> And it really felt daft to look for queue 0 to get the peer address
> of the controller.
> Unless we declare TCP the odd man out, and store the peer address
> per controller. Certainly would make sense for FC and loop.
It will never be different, I say just take it from queue 0...
prev parent reply other threads:[~2024-03-21 9:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 14:40 [PATCHv2 0/7] nvmet: debugfs support Hannes Reinecke
2024-03-20 14:40 ` [PATCH 1/7] nvmet: add " Hannes Reinecke
2024-03-20 14:40 ` [PATCH 2/7] nvmet: add debugfs support for queues Hannes Reinecke
2024-03-20 14:40 ` [PATCH 3/7] nvmet-tcp: implement queue_peer_traddr() Hannes Reinecke
2024-03-20 23:11 ` Sagi Grimberg
2024-03-21 6:56 ` Hannes Reinecke
2024-03-20 14:40 ` [PATCH 4/7] nvmet-rdma: " Hannes Reinecke
2024-03-20 14:40 ` [PATCH 5/7] nvmet-fc: " Hannes Reinecke
2024-03-20 14:40 ` [PATCH 6/7] nvme-fcloop: implement 'host_traddr' Hannes Reinecke
2024-03-20 14:40 ` [PATCH 7/7] lpfc_nvmet: " Hannes Reinecke
2024-03-20 23:07 ` [PATCHv2 0/7] nvmet: debugfs support Sagi Grimberg
2024-03-21 6:55 ` Hannes Reinecke
2024-03-21 8:59 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bea2b12-e043-4599-93ee-0874ed27f87c@grimberg.me \
--to=sagi@grimberg.me \
--cc=hare@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).