From: Nilay Shroff <nilay@linux.ibm.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: "Engel, Amit" <Amit.Engel@dell.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"Cohen, Yonatan" <Yonatan.Cohen@dell.com>,
Gregory Joyce <gjoyce@ibm.com>
Subject: Re: nvme-cli ‘nvme connect’ --duplicate-connect flag (-D) is not supported anymore
Date: Wed, 3 Apr 2024 18:57:15 +0530 [thread overview]
Message-ID: <4c990147-1ed8-4fb5-9f8f-dde537eab7b9@linux.ibm.com> (raw)
In-Reply-To: <endkd6bc5yooykdv4kkfb6uvijpkhlic6g7qut6yg5342cjo6j@cvmjm7hy6wk7>
On 4/3/24 18:18, Daniel Wagner wrote:
> On Wed, Apr 03, 2024 at 06:07:29PM +0530, Nilay Shroff wrote:
>> I think this is a bug in nvme-cli.
>
> Yes, regression from
>
> 07d6b911e081 ("fabrics: Do not attempt to reconnect to already connected
> ctrls")
>
>> If you want to use nvme-cli then you may try this patch:
>>
>> --- a/fabrics.c
>> +++ b/fabrics.c
>> @@ -999,7 +999,7 @@ int nvmf_connect(const char *desc, int argc, char **argv)
>> };
>>
>> c = lookup_ctrl(h, &trcfg);
>> - if (c && nvme_ctrl_get_name(c)) {
>> + if (c && nvme_ctrl_get_name(c) && !cfg.duplicate_connect) {
>> fprintf(stderr, "already connected\n");
>> errno = EALREADY;
>> goto out_free;
>>
>
> Care to send a proper patch?
>
Sorry my bad. I will send a proper patch in next mail.
Thanks,
--Nilay
prev parent reply other threads:[~2024-04-03 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 10:32 nvme-cli ‘nvme connect’ --duplicate-connect flag (-D) is not supported anymore Engel, Amit
2024-04-03 12:37 ` Nilay Shroff
2024-04-03 12:48 ` Daniel Wagner
2024-04-03 13:27 ` Nilay Shroff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c990147-1ed8-4fb5-9f8f-dde537eab7b9@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=Amit.Engel@dell.com \
--cc=Yonatan.Cohen@dell.com \
--cc=dwagner@suse.de \
--cc=gjoyce@ibm.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).