From: Sagi Grimberg <sagi@grimberg.me>
To: Kanchan Joshi <joshi.k@samsung.com>, Christoph Hellwig <hch@lst.de>
Cc: kbusch@kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 2/2] nvme: reduce a repeated ZNS check
Date: Fri, 3 May 2024 10:38:45 +0300 [thread overview]
Message-ID: <4038f7f6-4a2e-47b8-be17-d9f59300d26b@grimberg.me> (raw)
In-Reply-To: <3394a7a9-dda5-204e-dc5f-04a5512770a0@samsung.com>
On 5/2/24 11:44, Kanchan Joshi wrote:
> On 5/2/2024 12:43 PM, Christoph Hellwig wrote:
>> Not sure there is much of a point do de-duplicate two instances of
>> compile time condition + trivial const comparison?
>>
> I also don't see it as a [micro] optimization. But this if condition
> seemed too long to be present twice.
Seems a bit redundant to me.
prev parent reply other threads:[~2024-05-03 7:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240502064149epcas5p4be127b8e22874b76bb41ce25c29263f9@epcas5p4.samsung.com>
2024-05-02 6:34 ` [PATCH 0/2] cleanup Kanchan Joshi
[not found] ` <CGME20240502064150epcas5p3b6461ca0466650cd0296089d257ff861@epcas5p3.samsung.com>
2024-05-02 6:34 ` [PATCH 1/2] nvme: remove sgs and sws Kanchan Joshi
2024-05-02 7:12 ` Christoph Hellwig
2024-05-03 7:36 ` Sagi Grimberg
[not found] ` <CGME20240502064151epcas5p3834c50bcaea2c8db2d24fc30b0957ff0@epcas5p3.samsung.com>
2024-05-02 6:34 ` [PATCH 2/2] nvme: reduce a repeated ZNS check Kanchan Joshi
2024-05-02 7:13 ` Christoph Hellwig
2024-05-02 8:44 ` Kanchan Joshi
2024-05-03 7:38 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4038f7f6-4a2e-47b8-be17-d9f59300d26b@grimberg.me \
--to=sagi@grimberg.me \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).