From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Sagi Grimberg <sagi@grimberg.me>,
"soni.ankit@samsung.com" <soni.ankit@samsung.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"sathya.m@samsung.com" <sathya.m@samsung.com>,
"d.palani@samsung.com" <d.palani@samsung.com>,
"axboe@fb.com" <axboe@fb.com>,
"prakash.bv@samsung.com" <prakash.bv@samsung.com>,
"anshul@samsung.com" <anshul@samsung.com>,
"ankitvvsoni@gmail.com" <ankitvvsoni@gmail.com>,
"hch@lst.de" <hch@lst.de>,
"kbusch@kernel.org" <kbusch@kernel.org>
Subject: Re: [PATCH 1/1] nvme-tcp: check for invalid request
Date: Tue, 16 Apr 2024 02:43:12 +0000 [thread overview]
Message-ID: <2941218d-48bb-4f0f-a166-cdfe8547491e@nvidia.com> (raw)
In-Reply-To: <516a90cb-c03f-4474-8456-056bb3bd87fc@grimberg.me>
On 4/8/24 04:08, Sagi Grimberg wrote:
>
>
> On 08/04/2024 7:53, soni.ankit@samsung.com wrote:
>> From: Ankit Soni <soni.ankit@samsung.com>
>>
>> The blk_mq_tag_to_rq() returns NULL for invalid tag.
>> Added check condition to prevent NULL Pointer derefernece.
>
> Does this fix an actual bug? Or a theoretic one?
if it does fix actual bug then why not add a blktest as I don'
think we have this condition covered because we now triggering
error path, unless I'm missing something ...
-ck
prev parent reply other threads:[~2024-04-16 2:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240408102150epcas5p2d5b4c3460fca7fe58520254a2466271b@epcas5p2.samsung.com>
2024-04-08 4:53 ` [PATCH 1/1] nvme-tcp: check for invalid request soni.ankit
2024-04-08 11:08 ` Sagi Grimberg
2024-04-16 2:43 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2941218d-48bb-4f0f-a166-cdfe8547491e@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=ankitvvsoni@gmail.com \
--cc=anshul@samsung.com \
--cc=axboe@fb.com \
--cc=d.palani@samsung.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=prakash.bv@samsung.com \
--cc=sagi@grimberg.me \
--cc=sathya.m@samsung.com \
--cc=soni.ankit@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).