From: John Meneghini <jmeneghi@redhat.com>
To: kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, emilne@redhat.com
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
jmeneghi@redhat.com, jrani@purestorage.com,
randyj@purestorage.com, hare@kernel.org, constg@il.ibm.com,
aviv.coro@ibm.com
Subject: [PATCH v2 3/3] nvme: multipath: Invalidate current_path when changing iopolicy
Date: Thu, 9 May 2024 16:29:29 -0400 [thread overview]
Message-ID: <20240509202929.831680-4-jmeneghi@redhat.com> (raw)
In-Reply-To: <20231107212331.9413-1-emilne@redhat.com>
From: "Ewan D. Milne" <emilne@redhat.com>
When switching back to numa from round-robin, current_path may refer to
a different path than the one numa would have selected, and it is desirable
to have consistent behavior.
Tested-by: John Meneghini <jmeneghi@redhat.com>
Signed-off-by: Ewan D. Milne <emilne@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
drivers/nvme/host/multipath.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
index 02baadb45c82..d916a5ddf5d4 100644
--- a/drivers/nvme/host/multipath.c
+++ b/drivers/nvme/host/multipath.c
@@ -862,6 +862,7 @@ void nvme_subsys_iopolicy_update(struct nvme_subsystem *subsys, int iopolicy)
mutex_lock(&nvme_subsystems_lock);
list_for_each_entry(ctrl, &subsys->ctrls, subsys_entry) {
atomic_set(&ctrl->nr_active, 0);
+ nvme_mpath_clear_ctrl_paths(ctrl);
}
mutex_unlock(&nvme_subsystems_lock);
}
--
2.39.3
prev parent reply other threads:[~2024-05-09 20:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 21:23 [PATCH 1/3] nvme: multipath: Implemented new iopolicy "queue-depth" Ewan D. Milne
2023-11-07 21:23 ` [PATCH 2/3] nvme: multipath: only update ctrl->nr_active when using queue-depth iopolicy Ewan D. Milne
2023-11-07 21:42 ` Chaitanya Kulkarni
2023-11-07 21:53 ` Keith Busch
2023-11-07 22:03 ` Ewan Milne
2023-11-08 8:09 ` Christoph Hellwig
2023-11-08 16:58 ` John Meneghini
2023-11-08 18:38 ` Ewan Milne
2023-11-10 1:18 ` Uday Shankar
2023-11-13 21:16 ` Ewan Milne
2023-11-07 21:23 ` [PATCH 3/3] nvme: multipath: Invalidate current_path when changing iopolicy Ewan D. Milne
2023-11-08 8:10 ` Christoph Hellwig
2023-11-07 21:40 ` [PATCH 1/3] nvme: multipath: Implemented new iopolicy "queue-depth" Chaitanya Kulkarni
2023-11-07 21:46 ` Chaitanya Kulkarni
2023-11-07 21:56 ` Ewan Milne
2023-11-07 23:32 ` John Meneghini
2023-11-08 4:14 ` Chaitanya Kulkarni
2023-11-07 21:49 ` Keith Busch
2023-11-07 22:01 ` Ewan Milne
2023-11-07 22:14 ` Keith Busch
2024-05-09 20:29 ` [PATCH v2 0/3] nvme: queue-depth multipath iopolicy John Meneghini
2024-05-09 20:29 ` [PATCH v2 1/3] nvme: multipath: Implemented new iopolicy "queue-depth" John Meneghini
2024-05-09 20:29 ` [PATCH v2 2/3] nvme: multipath: only update ctrl->nr_active when using queue-depth iopolicy John Meneghini
2024-05-09 20:29 ` John Meneghini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509202929.831680-4-jmeneghi@redhat.com \
--to=jmeneghi@redhat.com \
--cc=aviv.coro@ibm.com \
--cc=constg@il.ibm.com \
--cc=emilne@redhat.com \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=jrani@purestorage.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=randyj@purestorage.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).