From: Christoph Hellwig <hch@lst.de>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: `nvme_disable_ctrl()` takes 411 ms on a Dell XPS 13 with SK hynix PC300 NVMEe
Date: Wed, 1 May 2024 06:51:45 +0200 [thread overview]
Message-ID: <20240501045145.GA32110@lst.de> (raw)
In-Reply-To: <19a6071a-7fb8-4e0f-8050-6f3ba5ee4774@molgen.mpg.de>
On Wed, May 01, 2024 at 06:29:12AM +0200, Paul Menzel wrote:
> Could a warning be logged, when this takes more than 50 ms with a hint that
> the disk vendor should improve their firmware?
Not sure why we'd warn about it. A clean shutdown can definitively take
some time and there's nothing tha forbids it. I don't think a linux
message is going to have any effect on firmware engineering..
next prev parent reply other threads:[~2024-05-01 4:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 4:29 `nvme_disable_ctrl()` takes 411 ms on a Dell XPS 13 with SK hynix PC300 NVMEe Paul Menzel
2024-05-01 4:51 ` Christoph Hellwig [this message]
2024-05-01 7:58 ` Keith Busch
2024-05-01 20:58 ` Paul Menzel
2024-05-01 22:03 ` Keith Busch
2024-05-02 6:04 ` Paul Menzel
2024-05-02 6:12 ` Paul Menzel
2024-05-02 8:43 ` Keith Busch
2024-05-02 15:57 ` Jeremy Allison
2024-05-03 5:52 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240501045145.GA32110@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=pmenzel@molgen.mpg.de \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).