From: Daniel Wagner <dwagner@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
James Smart <james.smart@broadcom.com>,
Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Daniel Wagner <dwagner@suse.de>
Subject: [PATCH v7 0/5] nvme-fabrics: short-circuit connect retries
Date: Tue, 30 Apr 2024 15:19:23 +0200 [thread overview]
Message-ID: <20240430131928.29766-1-dwagner@suse.de> (raw)
I've splitted the last patch into the hopefully non controversial part 'do not
retry when DNR is set' and the 'don't retry auth failures'. I hope we can get at
least the first few patches in and have a lively discussion on the final patch
at LSF.
changes:
v7:
- updated commit message patch #3
- split last patch so that only the DNR checks
are added first and then the auth reconnect failure test
v6:
- reorder series
- extended nvmf_should_reconnect
- added auth retry logic
- https://lore.kernel.org/linux-nvme/20240415124220.5433-1-dwagner@suse.de/
v5:
- nvme: do not mix kernel error code with nvme status
- nvmet: separate nvme status from dhchap status
- https://lore.kernel.org/linux-nvme/20240409093510.12321-1-dwagner@suse.de/
v4:
- rebased
- added 'nvme: fixes for authentication errors' series
- https://lore.kernel.org/all/20240404154500.2101-1-dwagner@suse.de/
v3:
- added my SOB tag
- fixed indention
- https://lore.kernel.org/linux-nvme/20240305080005.3638-1-dwagner@suse.de/
v2:
- refresh/rebase on current head
- extended blktests (nvme/045) to cover this case
(see separate post)
- https://lore.kernel.org/linux-nvme/20240304161006.19328-1-dwagner@suse.de/
v1:
- initial version
- https://lore.kernel.org/linux-nvme/20210623143250.82445-1-hare@suse.de/
Daniel Wagner (1):
nvme: do not retry authentication failures
Hannes Reinecke (4):
nvmet: lock config semaphore when accessing DH-HMAC-CHAP key
nvmet: return DHCHAP status codes from nvmet_setup_auth()
nvme: return kernel error codes for admin queue connect
nvme-fabrics: short-circuit reconnect retries
drivers/nvme/host/auth.c | 6 +--
drivers/nvme/host/core.c | 6 +--
drivers/nvme/host/fabrics.c | 51 ++++++++++++++++----------
drivers/nvme/host/fabrics.h | 2 +-
drivers/nvme/host/fc.c | 4 +-
drivers/nvme/host/nvme.h | 2 +-
drivers/nvme/host/rdma.c | 19 ++++++----
drivers/nvme/host/tcp.c | 22 +++++++----
drivers/nvme/target/auth.c | 22 +++++------
drivers/nvme/target/configfs.c | 22 ++++++++---
drivers/nvme/target/fabrics-cmd-auth.c | 49 +++++++++++++------------
drivers/nvme/target/fabrics-cmd.c | 11 +++---
drivers/nvme/target/nvmet.h | 8 ++--
13 files changed, 129 insertions(+), 95 deletions(-)
--
2.44.0
next reply other threads:[~2024-04-30 13:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 13:19 Daniel Wagner [this message]
2024-04-30 13:19 ` [PATCH v7 1/5] nvmet: lock config semaphore when accessing DH-HMAC-CHAP key Daniel Wagner
2024-04-30 13:19 ` [PATCH v7 2/5] nvmet: return DHCHAP status codes from nvmet_setup_auth() Daniel Wagner
2024-04-30 13:23 ` Christoph Hellwig
2024-04-30 13:19 ` [PATCH v7 3/5] nvme: return kernel error codes for admin queue connect Daniel Wagner
2024-04-30 13:19 ` [PATCH v7 4/5] nvme-fabrics: short-circuit reconnect retries Daniel Wagner
2024-04-30 13:19 ` [PATCH v7 5/5] nvme: do not retry authentication failures Daniel Wagner
2024-05-01 10:27 ` Sagi Grimberg
2024-05-01 10:13 ` [PATCH v7 0/5] nvme-fabrics: short-circuit connect retries Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430131928.29766-1-dwagner@suse.de \
--to=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).