From: Maurizio Lombardi <mlombard@redhat.com>
To: kbusch@kernel.org
Cc: sagi@grimberg.me, hare@suse.de, dwagner@suse.de,
linux-nvme@lists.infradead.org
Subject: [PATCH] nvmet-auth: print an error message if the auth timeout expires
Date: Wed, 24 Apr 2024 12:24:28 +0200 [thread overview]
Message-ID: <20240424102428.1298052-1-mlombard@redhat.com> (raw)
When the auth_expired_work fires, an error message should be printed
to inform the user that the authentication is failing because of
a timeout, so he doesn't get misleaded into thinking there is a bug
in the auth code when seeing messages like the following:
nvmet: nvmet_execute_auth_send: ctrl 1 qid 2 step mismatch (2 != 0)
nvmet: nvmet_execute_auth_send: failure incorrect message.
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
---
drivers/nvme/target/fabrics-cmd-auth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/target/fabrics-cmd-auth.c b/drivers/nvme/target/fabrics-cmd-auth.c
index eb7785be0ca7..7436ebda9f70 100644
--- a/drivers/nvme/target/fabrics-cmd-auth.c
+++ b/drivers/nvme/target/fabrics-cmd-auth.c
@@ -17,8 +17,8 @@ static void nvmet_auth_expired_work(struct work_struct *work)
struct nvmet_sq *sq = container_of(to_delayed_work(work),
struct nvmet_sq, auth_expired_work);
- pr_debug("%s: ctrl %d qid %d transaction %u expired, resetting\n",
- __func__, sq->ctrl->cntlid, sq->qid, sq->dhchap_tid);
+ pr_err("%s: ctrl %d qid %d transaction %u expired, resetting\n",
+ __func__, sq->ctrl->cntlid, sq->qid, sq->dhchap_tid);
sq->dhchap_step = NVME_AUTH_DHCHAP_MESSAGE_NEGOTIATE;
sq->dhchap_tid = -1;
}
--
2.39.3
next reply other threads:[~2024-04-24 10:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 10:24 Maurizio Lombardi [this message]
2024-04-24 12:15 ` [PATCH] nvmet-auth: print an error message if the auth timeout expires Maurizio Lombardi
2024-04-24 13:11 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424102428.1298052-1-mlombard@redhat.com \
--to=mlombard@redhat.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).