From: Daniel Wagner <dwagner@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
James Smart <james.smart@broadcom.com>,
Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Daniel Wagner <dwagner@suse.de>
Subject: [PATCH v5 0/6] nvme-fabrics: short-circuit connect retries
Date: Tue, 9 Apr 2024 11:35:04 +0200 [thread overview]
Message-ID: <20240409093510.12321-1-dwagner@suse.de> (raw)
The first patch returns only kernel error codes now and avoids overwriting error
codes later. Thje newly introduced helper for deciding if a reconnect should be
attempted is the only place where we have the logic (and documentation).
On the target side I've separate the nvme status from the dhchap status handling
which made it a bit clearer. I was tempted to refactor the code in
nvmet_execute_auth_send to avoid hitting the 80 chars limit but didn't came up
with something nice yet. So let's keep this change at a minimum before any
refactoring attempts.
I've tested with blktests and also an real hardware for nvme-fc.
changes:
v5:
- nvme: do not mix kernel error code with nvme status
- nvmet: separate nvme status from dhchap status
- https://lore.kernel.org/all/20240404154500.2101-1-dwagner@suse.de/
v4:
- rebased
- added 'nvme: fixes for authentication errors' series
https://lore.kernel.org/linux-nvme/20240301112823.132570-1-hare@kernel.org/
v3:
- added my SOB tag
- fixed indention
- https://lore.kernel.org/linux-nvme/20240305080005.3638-1-dwagner@suse.de/
v2:
- refresh/rebase on current head
- extended blktests (nvme/045) to cover this case
(see separate post)
- https://lore.kernel.org/linux-nvme/20240304161006.19328-1-dwagner@suse.de/
v1:
- initial version
- https://lore.kernel.org/linux-nvme/20210623143250.82445-1-hare@suse.de/
Daniel Wagner (1):
nvme-fc: use nvme_ctrl_reconnect to decide reconnect attempts
Hannes Reinecke (5):
nvme: authentication error are always non-retryable
nvmet: lock config semaphore when accessing DH-HMAC-CHAP key
nvme-tcp: short-circuit reconnect retries
nvme-rdma: short-circuit reconnect retries
nvmet: return DHCHAP status codes from nvmet_setup_auth()
drivers/nvme/host/core.c | 6 ++--
drivers/nvme/host/fabrics.c | 25 ++++++-------
drivers/nvme/host/fc.c | 4 +--
drivers/nvme/host/nvme.h | 26 +++++++++++++-
drivers/nvme/host/rdma.c | 22 ++++++++----
drivers/nvme/host/tcp.c | 23 +++++++-----
drivers/nvme/target/auth.c | 22 ++++++------
drivers/nvme/target/configfs.c | 22 +++++++++---
drivers/nvme/target/fabrics-cmd-auth.c | 49 +++++++++++++-------------
drivers/nvme/target/fabrics-cmd.c | 11 +++---
drivers/nvme/target/nvmet.h | 8 ++---
11 files changed, 134 insertions(+), 84 deletions(-)
--
2.44.0
next reply other threads:[~2024-04-09 9:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 9:35 Daniel Wagner [this message]
2024-04-09 9:35 ` [PATCH v5 1/6] nvme: authentication error are always non-retryable Daniel Wagner
2024-04-09 13:59 ` Christoph Hellwig
2024-04-09 20:16 ` Sagi Grimberg
2024-04-09 20:26 ` Sagi Grimberg
2024-04-10 6:52 ` Daniel Wagner
2024-04-10 10:21 ` Sagi Grimberg
2024-04-10 12:05 ` Hannes Reinecke
2024-04-10 13:50 ` Sagi Grimberg
2024-04-11 7:11 ` Hannes Reinecke
2024-04-11 8:37 ` Sagi Grimberg
2024-04-09 9:35 ` [PATCH v5 2/6] nvmet: lock config semaphore when accessing DH-HMAC-CHAP key Daniel Wagner
2024-04-09 9:35 ` [PATCH v5 3/6] nvme-tcp: short-circuit reconnect retries Daniel Wagner
2024-04-09 13:59 ` Christoph Hellwig
2024-04-09 20:20 ` Sagi Grimberg
2024-04-10 6:01 ` Hannes Reinecke
2024-04-09 20:40 ` Sagi Grimberg
2024-04-10 10:06 ` Daniel Wagner
2024-04-09 9:35 ` [PATCH v5 4/6] nvme-rdma: " Daniel Wagner
2024-04-09 14:00 ` Christoph Hellwig
2024-04-09 14:19 ` Keith Busch
2024-04-09 20:21 ` Sagi Grimberg
2024-04-09 20:28 ` Sagi Grimberg
2024-04-12 2:50 ` Keith Busch
2024-04-09 9:35 ` [PATCH v5 5/6] nvme-fc: use nvme_ctrl_reconnect to decide reconnect attempts Daniel Wagner
2024-04-09 14:01 ` Christoph Hellwig
2024-04-09 9:35 ` [PATCH v5 6/6] nvmet: return DHCHAP status codes from nvmet_setup_auth() Daniel Wagner
2024-04-09 14:03 ` Christoph Hellwig
2024-04-09 20:23 ` Sagi Grimberg
2024-04-10 6:45 ` Hannes Reinecke
2024-04-12 0:35 ` [PATCH v5 0/6] nvme-fabrics: short-circuit connect retries Keith Busch
2024-04-12 7:24 ` Daniel Wagner
2024-04-12 15:24 ` Keith Busch
2024-04-14 8:34 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409093510.12321-1-dwagner@suse.de \
--to=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).