From: Daniel Wagner <dwagner@suse.de>
To: James Smart <james.smart@broadcom.com>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Daniel Wagner <dwagner@suse.de>
Subject: [PATCH v2 0/5] nvme-fc: fix blktests nvme/041
Date: Wed, 21 Feb 2024 14:23:59 +0100 [thread overview]
Message-ID: <20240221132404.6311-1-dwagner@suse.de> (raw)
As suggested by Keith I've merged the new flag for nvme-fabrics with the last
patch. I also added some information why nvme-fc is handling the initial connect
attempt differently as requested by Christoph.
The new flag is called connect_async and the default is false/0. I've tested
with a patched nvme-cli/libnvme version and all looks good. When this series is
accepted I'll update nvme-cli/libnvme accordingly. Note, that even with an older
nvme-cli the blktests (especially nvme/041) will pass with a newer kernel.
(nvme/048 is still fails but this is a different problem. On my TODO list)
changes:
v2:
- renamed flag to connect_async, default false
- add info to commit message why nvme-fc is different
- merged connect_async with 'nvme-fc: wait for
initial connect attempt to finish'
v1:
- renamed 'nvme-fc: redesign locking and refcounting'
to 'nvme-fc: reorder ctrl ref counting and cleanup code path'
- testing with scsi/nvme dev_loss_tmo on real hw
- removed rport ref counting part
- collected RB tags
- https://lore.kernel.org/linux-nvme/20240219131531.15134-1-dwagner@suse.de/
v0:
- initial version
- https://lore.kernel.org/linux-nvme/20240216084526.14133-1-dwagner@suse.de/
Daniel Wagner (5):
nvme-fc: rename free_ctrl callback to match name pattern
nvme-fc: do not retry when auth fails or connection is refused
nvme-fabrics: introduce ref counting for nvmf_ctrl_options
nvme-fc: reorder ctrl ref counting and cleanup code path
nvme-fc: wait for initial connect attempt to finish
drivers/nvme/host/fabrics.c | 39 +++++++++-
drivers/nvme/host/fabrics.h | 9 ++-
drivers/nvme/host/fc.c | 145 +++++++++++++++++-------------------
drivers/nvme/host/rdma.c | 18 +++--
drivers/nvme/host/tcp.c | 21 ++++--
drivers/nvme/target/loop.c | 19 +++--
6 files changed, 152 insertions(+), 99 deletions(-)
--
2.43.1
next reply other threads:[~2024-02-21 13:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 13:23 Daniel Wagner [this message]
2024-02-21 13:24 ` [PATCH v2 1/5] nvme-fc: rename free_ctrl callback to match name pattern Daniel Wagner
2024-02-21 15:52 ` Hannes Reinecke
2024-03-07 10:21 ` Sagi Grimberg
2024-02-21 13:24 ` [PATCH v2 2/5] nvme-fc: do not retry when auth fails or connection is refused Daniel Wagner
2024-02-21 15:53 ` Hannes Reinecke
2024-02-21 16:37 ` Daniel Wagner
2024-02-22 6:46 ` Hannes Reinecke
2024-02-22 7:45 ` Daniel Wagner
2024-02-22 17:02 ` Daniel Wagner
2024-02-23 11:58 ` Hannes Reinecke
2024-03-07 10:25 ` Sagi Grimberg
2024-03-07 12:43 ` Daniel Wagner
2024-02-21 13:24 ` [PATCH v2 3/5] nvme-fabrics: introduce ref counting for nvmf_ctrl_options Daniel Wagner
2024-02-21 15:54 ` Hannes Reinecke
2024-03-07 10:27 ` Sagi Grimberg
2024-03-11 17:36 ` Daniel Wagner
2024-03-11 19:28 ` Hannes Reinecke
2024-02-21 13:24 ` [PATCH v2 4/5] nvme-fc: reorder ctrl ref counting and cleanup code path Daniel Wagner
2024-02-21 13:24 ` [PATCH v2 5/5] nvme-fc: wait for initial connect attempt to finish Daniel Wagner
2024-03-07 10:33 ` Sagi Grimberg
2024-02-21 18:04 ` [PATCH v2 0/5] nvme-fc: fix blktests nvme/041 Keith Busch
2024-03-06 14:35 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240221132404.6311-1-dwagner@suse.de \
--to=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).