From: Dan Williams <dan.j.williams@intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel@pengutronix.de, linux-nvdimm <linux-nvdimm@lists.01.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] libnvdimm: Make remove callback return void
Date: Tue, 16 Feb 2021 19:37:58 -0800 [thread overview]
Message-ID: <CAPcyv4jVw6o7Yznxs7UDMnSoJLozx86v5YCg6YZGeGm6emyooQ@mail.gmail.com> (raw)
In-Reply-To: <20210212171043.2136580-2-u.kleine-koenig@pengutronix.de>
On Fri, Feb 12, 2021 at 9:21 AM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> All drivers return 0 in their remove callback and the driver core ignores
> the return value of nvdimm_bus_remove() anyhow. So simplify by changing
> the driver remove callback to return void and return 0 unconditionally
> to the upper layer.
Looks good, thanks.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2021-02-17 3:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 17:10 [PATCH 1/2] libnvdimm: simplify nvdimm_remove() Uwe Kleine-König
2021-02-12 17:10 ` [PATCH 2/2] libnvdimm: Make remove callback return void Uwe Kleine-König
2021-02-17 3:37 ` Dan Williams [this message]
2021-02-17 1:40 ` [PATCH 1/2] libnvdimm: simplify nvdimm_remove() Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4jVw6o7Yznxs7UDMnSoJLozx86v5YCg6YZGeGm6emyooQ@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).