linux-numa.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

From: "Rick \"Zero_Chaos\" Farina" <zerochaos@gentoo.org>
To: linux-numa@vger.kernel.org
Subject: [PATCH] fix numactl test
Date: Sun, 03 May 2015 22:35:33 -0400	[thread overview]
Message-ID: <5546DAF5.1010805@gentoo.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1515 bytes --]

I apologize if this is already handled, however, a quick google search
didn't help me find any version control systems so I'm submitting here.

In Gentoo we got a bug, where numactl fails tests if it isn't already
installed:

https://bugs.gentoo.org/show_bug.cgi?id=502586

./bind_range: line 92: numactl: command not found
./bind_range: line 93: numactl: command not found

The origin is fairly trivial, it appears that on the noted lines it's
calling "numactl" instead of "../numactl" like it should.  Which means
it will try to use an installed numactl (possibly older) and fail if it
isn't installed at all.

Here is the tested and trivial patch to fix this behavior, please accept it.

Signed-off-by: "Rick Farina <zerochaos@gentoo.org>"
diff -Naur numactl-2.0.10-orig/test/bind_range
numactl-2.0.10/test/bind_range
--- numactl-2.0.10-orig/test/bind_range	2015-05-03 22:23:31.095600314 -0400
+++ numactl-2.0.10/test/bind_range	2015-05-03 22:25:29.107592557 -0400
@@ -93,8 +93,8 @@

 HIGHESTCPU=$(grep 'processor' /proc/cpuinfo | tail -n1 | cut -f2 -d':')
 HIGHESTCPU=$(echo $HIGHESTCPU | cut -f2 -d' ')
-HIGHESTNODE=$(numactl -H | grep -e 'node [0-9]* cpus' | tail -n1 | cut
-f2 -d' ')
-LOWESTNODE=$(numactl -H | grep -e 'node [0-9]* cpus' | head -n1 | cut
-f2 -d' ')
+HIGHESTNODE=$(../numactl -H | grep -e 'node [0-9]* cpus' | tail -n1 |
cut -f2 -d' ')
+LOWESTNODE=$(../numactl -H | grep -e 'node [0-9]* cpus' | head -n1 |
cut -f2 -d' ')

 get_mask



Thanks,
Zero


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

next             reply	other threads:[~2015-05-04  2:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-04  2:35 Rick "Zero_Chaos" Farina [this message]
2015-05-04 20:29 ` [PATCH] fix numactl test Filipe Brandenburger
2015-05-05  4:32   ` Rick "Zero_Chaos" Farina
2015-05-05 15:55     ` Filipe Brandenburger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5546DAF5.1010805@gentoo.org \
    --to=zerochaos@gentoo.org \
    --cc=linux-numa@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).