From: Brian Foster <bfoster@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org, linux-nilfs@vger.kernel.org,
Hugh Dickins <hughd@google.com>,
Matthew Wilcox <willy@infradead.org>,
cluster-devel@redhat.com, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-ext4@vger.kernel.org, linux-afs@lists.infradead.org,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 4/9] shmem: remove shmem_get_partial_folio
Date: Wed, 18 Jan 2023 11:50:26 -0500 [thread overview]
Message-ID: <Y8gjUhcRYkRuxLDq@bfoster> (raw)
In-Reply-To: <20230118164358.GD7584@lst.de>
On Wed, Jan 18, 2023 at 05:43:58PM +0100, Christoph Hellwig wrote:
> On Wed, Jan 18, 2023 at 08:57:05AM -0500, Brian Foster wrote:
> > This all seems reasonable to me at a glance, FWIW, but I am a little
> > curious why this wouldn't split up into two changes. I.e., switch this
> > over to filemap_get_entry() to minimally remove the FGP_ENTRY dependency
> > without a behavior change, then (perhaps after the next patch) introduce
> > SGP_FIND in a separate patch. That makes it easier to review and
> > potentially undo if it happens to pose a problem in the future. Hm?
>
> The minimal change to filemap_get_entry would require to add the
> lock, check mapping and retry loop and thus add a fair amount of
> code. So I looked for ways to avoid that and came up with this
> version. But if there is a strong preference to first open code
> the logic and then later consolidate it I could do that.
>
Ok. Not a strong preference from me. I don't think it's worth
complicating that much just to split up.
Brian
next prev parent reply other threads:[~2023-01-18 16:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230118094329.9553-1-hch@lst.de>
2023-01-18 9:43 ` [PATCH 1/9] mm: don't look at xarray value entries in split_huge_pages_in_file Christoph Hellwig
2023-01-18 13:47 ` Matthew Wilcox
2023-01-18 9:43 ` [PATCH 2/9] mm: make mapping_get_entry available outside of filemap.c Christoph Hellwig
2023-01-18 13:49 ` Matthew Wilcox
2023-01-18 9:43 ` [PATCH 3/9] mm: use filemap_get_entry in filemap_get_incore_folio Christoph Hellwig
2023-01-18 13:49 ` Matthew Wilcox
2023-01-18 9:43 ` [PATCH 4/9] shmem: remove shmem_get_partial_folio Christoph Hellwig
2023-01-18 13:57 ` Brian Foster
2023-01-18 16:43 ` Christoph Hellwig
2023-01-18 16:50 ` Brian Foster [this message]
2023-01-18 9:43 ` [PATCH 5/9] shmem: open code the page cache lookup in shmem_get_folio_gfp Christoph Hellwig
2023-01-18 9:43 ` [PATCH 6/9] mm: remove FGP_ENTRY Christoph Hellwig
2023-01-18 9:43 ` [PATCH 7/9] gfs2: handle a NULL folio in gfs2_jhead_process_page Christoph Hellwig
2023-01-18 16:00 ` Matthew Wilcox
2023-01-18 16:24 ` Andreas Gruenbacher
2023-01-18 16:42 ` [Cluster-devel] " Christoph Hellwig
2023-01-18 9:43 ` [PATCH 8/9] btrfs: handle a NULL folio in extent_range_redirty_for_io Christoph Hellwig
2023-01-18 16:08 ` Matthew Wilcox
[not found] ` <Y8gZmTFB6vCivxsY-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2023-01-18 16:42 ` Christoph Hellwig
2023-01-18 9:43 ` [PATCH 9/9] mm: return an ERR_PTR from __filemap_get_folio Christoph Hellwig
2023-01-18 12:39 ` Ryusuke Konishi
[not found] ` <CAKFNMomcjvUSh-nS1MqptYdiT-1frRsmHgx2mHBBm_588kprrQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-01-18 16:42 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8gjUhcRYkRuxLDq@bfoster \
--to=bfoster@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cluster-devel@redhat.com \
--cc=hch@lst.de \
--cc=hughd@google.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).