From: Ryusuke Konishi <konishi.ryusuke@gmail.com>
To: Jeongjun Park <aha310510@gmail.com>
Cc: linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+2e22057de05b9f3b30d8@syzkaller.appspotmail.com
Subject: Re: [PATCH] nilfs: Fix OOB in nilfs_set_de_type
Date: Tue, 16 Apr 2024 01:44:59 +0900 [thread overview]
Message-ID: <CAKFNMon3DWhBxMor7UNqTcrTdms6nUQF+=uWDeEc0wWerH4sOQ@mail.gmail.com> (raw)
In-Reply-To: <20240415154002.151149-1-aha310510@gmail.com>
On Tue, Apr 16, 2024 at 12:40 AM Jeongjun Park wrote:
>
>
> static void nilfs_set_de_type(struct nilfs_dir_entry *de, struct inode *inode)
> {
> umode_t mode = inode->i_mode;
>
> de->file_type = nilfs_type_by_mode[(mode & S_IFMT)>>S_SHIFT]; // oob
> }
>
>
>
> The size of the nilfs_type_by_mode array in the fs/nilfs2/dir.c file is defined
> as "S_IFMT >> S_SHIFT", but the nilfs_set_de_type() function, which uses this array,
> specifies the index to read from the array in the same way as "(mode & S_IFMT) >> S_SHIFT".
>
> However, when the index is determined this way, an out-of-bounds (OOB) error occurs by referring
> to an index that is 1 larger than the array size when the condition "mode & S_IFMT == S_IFMT" is satisfied.
> Therefore, a patch to resize the nilfs_type_by_mode array should be applied to prevent OOB errors.
>
>
>
> Reported-and-tested-by: syzbot+2e22057de05b9f3b30d8@syzkaller.appspotmail.com
> Fixes: 2ba466d74ed7 ("nilfs2: directory entry operations")
> Signed-off-by: Jeongjun Park <aha310510@gmail.com>
> ---
> fs/nilfs2/dir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nilfs2/dir.c b/fs/nilfs2/dir.c
> index bc846b904b68..aee40db7a036 100644
> --- a/fs/nilfs2/dir.c
> +++ b/fs/nilfs2/dir.c
> @@ -240,7 +240,7 @@ nilfs_filetype_table[NILFS_FT_MAX] = {
>
> #define S_SHIFT 12
> static unsigned char
> -nilfs_type_by_mode[S_IFMT >> S_SHIFT] = {
> +nilfs_type_by_mode[(S_IFMT >> S_SHIFT) + 1] = {
> [S_IFREG >> S_SHIFT] = NILFS_FT_REG_FILE,
> [S_IFDIR >> S_SHIFT] = NILFS_FT_DIR,
> [S_IFCHR >> S_SHIFT] = NILFS_FT_CHRDEV,
Thank you for your prompt response and posting the patch.
A little formatting and tag editing is required, but it's okay.
I'll handle this patch.
Thanks,
Ryusuke Konishi
prev parent reply other threads:[~2024-04-15 16:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 15:40 [PATCH] nilfs: Fix OOB in nilfs_set_de_type Jeongjun Park
2024-04-15 16:44 ` Ryusuke Konishi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKFNMon3DWhBxMor7UNqTcrTdms6nUQF+=uWDeEc0wWerH4sOQ@mail.gmail.com' \
--to=konishi.ryusuke@gmail.com \
--cc=aha310510@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=syzbot+2e22057de05b9f3b30d8@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).