From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc: <linux-nilfs@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nilfs2: fix nilfs_btree_commit_convert_and_insert() kernel-doc
Date: Tue, 7 May 2024 15:54:06 -0700 [thread overview]
Message-ID: <9d9c2912-e965-435d-b0d9-7e6071c24ab3@quicinc.com> (raw)
In-Reply-To: <CAKFNMomG+GuKJ53WmdWFONtimhbanKU-B_ZTdt5sEFxcuYxJ3w@mail.gmail.com>
On 5/7/2024 3:45 PM, Ryusuke Konishi wrote:
> On Wed, May 8, 2024 at 7:23 AM Jeff Johnson wrote:
>>
>> Fix the following reported by make W=1:
>>
>> fs/nilfs2/btree.c:1871: warning: Function parameter or struct member 'btree' not described in 'nilfs_btree_convert_and_insert'
>> fs/nilfs2/btree.c:1871: warning: Excess function parameter 'bmap' description in 'nilfs_btree_convert_and_insert'
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>> fs/nilfs2/btree.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/nilfs2/btree.c b/fs/nilfs2/btree.c
>> index 65659fa0372e..8299839b5129 100644
>> --- a/fs/nilfs2/btree.c
>> +++ b/fs/nilfs2/btree.c
>> @@ -1858,7 +1858,7 @@ nilfs_btree_commit_convert_and_insert(struct nilfs_bmap *btree,
>>
>> /**
>> * nilfs_btree_convert_and_insert -
>> - * @bmap:
>> + * @btree: bmap struct of btree
>> * @key:
>> * @ptr:
>> * @keys:
>>
>> ---
>> base-commit: dd5a440a31fae6e459c0d6271dddd62825505361
>> change-id: 20240507-nilfs_btree_convert_and_insert-kdoc-7753c4a6e7c3
>>
>
> Hi Jeff, thank you for posting.
>
> However, a fix for this kernel-doc warnings is already queued in the
> mm tree (to be merged in the next merge window).
>
> Please refer to the patch below:
>
> https://lkml.kernel.org/r/20240410075629.3441-3-konishi.ryusuke@gmail.com
> https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-nonmm-stable&id=3da9b9650acc3a2a0c3d3f4542b93d4abe9da1de
>
>
> Thanks,
> Ryusuke Konishi
Awesome that others are helping to clean these :)
Guess I should check lore before fixing so that I don't replicate work!
/jeff
prev parent reply other threads:[~2024-05-07 22:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 22:23 [PATCH] nilfs2: fix nilfs_btree_commit_convert_and_insert() kernel-doc Jeff Johnson
2024-05-07 22:45 ` Ryusuke Konishi
2024-05-07 22:54 ` Jeff Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d9c2912-e965-435d-b0d9-7e6071c24ab3@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=konishi.ryusuke@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).