From: Jeff Layton <jlayton@kernel.org>
To: Jan Kara <jack@suse.cz>, Trond Myklebust <trondmy@hammerspace.com>
Cc: anna@kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfs: Avoid flushing many pages with NFS_FILE_SYNC
Date: Sun, 26 May 2024 07:36:43 -0400 [thread overview]
Message-ID: <eb077defaf957f458b0c70c8f012ea15d866257a.camel@kernel.org> (raw)
In-Reply-To: <20240524161419.18448-1-jack@suse.cz>
On Fri, 2024-05-24 at 18:14 +0200, Jan Kara wrote:
> When we are doing WB_SYNC_ALL writeback, nfs submits write requests with
> NFS_FILE_SYNC flag to the server (which then generally treats it as an
> O_SYNC write). This helps to reduce latency for single requests but when
> submitting more requests, additional fsyncs on the server side hurt
> latency. NFS generally avoids this additional overhead by not setting
> NFS_FILE_SYNC if desc->pg_moreio is set.
>
> However this logic doesn't always work. When we do random 4k writes to a huge
> file and then call fsync(2), each page writeback is going to be sent with
> NFS_FILE_SYNC because after preparing one page for writeback, we start writing
> back next, nfs_do_writepage() will call nfs_pageio_cond_complete() which finds
> the page is not contiguous with previously prepared IO and submits is *without*
> setting desc->pg_moreio. Hence NFS_FILE_SYNC is used resulting in poor
> performance.
>
> Fix the problem by setting desc->pg_moreio in nfs_pageio_cond_complete() before
> submitting outstanding IO. This improves throughput of
> fsync-after-random-writes on my test SSD from ~70MB/s to ~250MB/s.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> fs/nfs/pagelist.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/fs/nfs/pagelist.c b/fs/nfs/pagelist.c
> index 6efb5068c116..040b6b79c75e 100644
> --- a/fs/nfs/pagelist.c
> +++ b/fs/nfs/pagelist.c
> @@ -1545,6 +1545,11 @@ void nfs_pageio_cond_complete(struct nfs_pageio_descriptor *desc, pgoff_t index)
> continue;
> } else if (index == prev->wb_index + 1)
> continue;
> + /*
> + * We will submit more requests after these. Indicate
> + * this to the underlying layers.
> + */
> + desc->pg_moreio = 1;
> nfs_pageio_complete(desc);
> break;
> }
Nice work!
Reviewed-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2024-05-26 11:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 16:14 [PATCH] nfs: Avoid flushing many pages with NFS_FILE_SYNC Jan Kara
2024-05-24 16:25 ` Trond Myklebust
2024-05-26 11:36 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb077defaf957f458b0c70c8f012ea15d866257a.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=anna@kernel.org \
--cc=jack@suse.cz \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).