From: Chuck Lever <chuck.lever@oracle.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna@kernel.org>,
Jeff Layton <jlayton@kernel.org>, Neil Brown <neilb@suse.de>,
Olga Kornievskaia <kolga@netapp.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Subject: Re: [PATCH v1 1/1] lockd: Use *-y instead of *-objs in Makefile
Date: Wed, 8 May 2024 12:04:28 -0400 [thread overview]
Message-ID: <ZjuijMla78l+sl5S@tissot.1015granger.net> (raw)
In-Reply-To: <20240508151951.1445074-1-andriy.shevchenko@linux.intel.com>
On Wed, May 08, 2024 at 06:19:38PM +0300, Andy Shevchenko wrote:
> *-objs suffix is reserved rather for (user-space) host programs while
> usually *-y suffix is used for kernel drivers (although *-objs works
> for that purpose for now).
>
> Let's correct the old usages of *-objs in Makefiles.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> Note, the original approach is weirdest from the existing.
> Only a few drivers use this (-objs-y) one most likely by mistake.
>
> fs/lockd/Makefile | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/fs/lockd/Makefile b/fs/lockd/Makefile
> index ac9f9d84510e..fe3e23dd29c3 100644
> --- a/fs/lockd/Makefile
> +++ b/fs/lockd/Makefile
> @@ -7,8 +7,7 @@ ccflags-y += -I$(src) # needed for trace events
>
> obj-$(CONFIG_LOCKD) += lockd.o
>
> -lockd-objs-y += clntlock.o clntproc.o clntxdr.o host.o svc.o svclock.o \
> - svcshare.o svcproc.o svcsubs.o mon.o trace.o xdr.o
> -lockd-objs-$(CONFIG_LOCKD_V4) += clnt4xdr.o xdr4.o svc4proc.o
> -lockd-objs-$(CONFIG_PROC_FS) += procfs.o
> -lockd-objs := $(lockd-objs-y)
> +lockd-y := clntlock.o clntproc.o clntxdr.o host.o svc.o svclock.o \
> + svcshare.o svcproc.o svcsubs.o mon.o trace.o xdr.o
> +lockd-$(CONFIG_LOCKD_V4) += clnt4xdr.o xdr4.o svc4proc.o
> +lockd-$(CONFIG_PROC_FS) += procfs.o
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>
Acked-by: Chuck Lever <chuck.lever@oracle.com>
Unless, of course, you'd like me to take this through the nfsd tree.
--
Chuck Lever
next prev parent reply other threads:[~2024-05-08 16:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 15:19 [PATCH v1 1/1] lockd: Use *-y instead of *-objs in Makefile Andy Shevchenko
2024-05-08 15:59 ` Benjamin Coddington
2024-05-08 16:04 ` Chuck Lever [this message]
2024-06-05 21:13 ` Andy Shevchenko
2024-06-06 13:40 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjuijMla78l+sl5S@tissot.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=Dai.Ngo@oracle.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anna@kernel.org \
--cc=jlayton@kernel.org \
--cc=kolga@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=tom@talpey.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).