From: Chuck Lever <chuck.lever@oracle.com>
To: trondmy@kernel.org
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/2] knfsd: LOOKUP can return an illegal error value
Date: Mon, 6 May 2024 12:52:20 -0400 [thread overview]
Message-ID: <ZjkKxPSV+iyH8Rer@tissot.1015granger.net> (raw)
In-Reply-To: <20240506163005.9990-1-trondmy@kernel.org>
On Mon, May 06, 2024 at 12:30:04PM -0400, trondmy@kernel.org wrote:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
>
> The 'NFS error' NFSERR_OPNOTSUPP is not described by any of the official
> NFS related RFCs, but appears to have snuck into some older .x files for
> NFSv2.
> Either way, it is not in RFC1094, RFC1813 or any of the NFSv4 RFCs, so
> should not be returned by the knfsd server, and particularly not by the
> "LOOKUP" operation.
>
> Instead, let's return NFSERR_STALE, which is more appropriate if the
> filesystem encodes the filehandle as FILEID_INVALID.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> ---
> fs/nfsd/nfsfh.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Hi, both applied to nfsd-next (for v6.10). Thanks!
> diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c
> index dbfa0ac13564..d41e7630eb7a 100644
> --- a/fs/nfsd/nfsfh.c
> +++ b/fs/nfsd/nfsfh.c
> @@ -572,7 +572,7 @@ fh_compose(struct svc_fh *fhp, struct svc_export *exp, struct dentry *dentry,
> _fh_update(fhp, exp, dentry);
> if (fhp->fh_handle.fh_fileid_type == FILEID_INVALID) {
> fh_put(fhp);
> - return nfserr_opnotsupp;
> + return nfserr_stale;
> }
>
> return 0;
> @@ -598,7 +598,7 @@ fh_update(struct svc_fh *fhp)
>
> _fh_update(fhp, fhp->fh_export, dentry);
> if (fhp->fh_handle.fh_fileid_type == FILEID_INVALID)
> - return nfserr_opnotsupp;
> + return nfserr_stale;
> return 0;
> out_bad:
> printk(KERN_ERR "fh_update: fh not verified!\n");
> --
> 2.45.0
>
--
Chuck Lever
prev parent reply other threads:[~2024-05-06 16:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 16:30 [PATCH 1/2] knfsd: LOOKUP can return an illegal error value trondmy
2024-05-06 16:30 ` [PATCH 2/2] NFS/knfsd: Remove the invalid NFS error 'NFSERR_OPNOTSUPP' trondmy
2024-05-06 16:52 ` Chuck Lever [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjkKxPSV+iyH8Rer@tissot.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).