From: Salvatore Bonaccorso <carnil@debian.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Steve Dickson <steved@redhat.com>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: Fails to build on arm{el,hf} with 64bit time_t: export-cache.c:110:51: error: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘time_t’ {aka ‘long long int’} [-Werror=format=]
Date: Thu, 2 May 2024 15:55:32 +0200 [thread overview]
Message-ID: <ZjObVI2tISaGfIcv@eldamar.lan> (raw)
In-Reply-To: <ZjONq6cf2MEmVSBK@tissot.1015granger.net>
Hi,
On Thu, May 02, 2024 at 08:57:15AM -0400, Chuck Lever wrote:
> On Thu, May 02, 2024 at 07:00:44AM +0200, Salvatore Bonaccorso wrote:
> > Hi all,
> >
> > On Sat, Apr 06, 2024 at 07:28:58PM +0000, Chuck Lever III wrote:
> > >
> > >
> > > > On Apr 6, 2024, at 3:15 PM, Salvatore Bonaccorso <carnil@debian.org> wrote:
> > > >
> > > > Hi Chuck, hi Steve,
> > > >
> > > > In Debian, as you might have heard there is a 64bit time_t
> > > > transition[1] ongoing affecting the armel and armhf architectures.
> > > > While doing so, nfs-utils was found to fail to build for those
> > > > architectures after the switch, reported in Debian as [2]. Vladimir
> > > > Petko from Ubuntu has as well filled it in [3].
> > > >
> > > > [1]: https://lists.debian.org/debian-devel-announce/2024/02/msg00005.html
> > > > [2]: https://bugs.debian.org/1067829
> > > > [3]: https://bugzilla.kernel.org/show_bug.cgi?id=218540
> > > >
> > > > The report is full-quoted below.
> > > >
> > > > Vladimir Petko has created a patch in the bugzilla which I'm attaching
> > > > here as well. If this is not an acceptable format due to missing
> > > > Signed-off's I'm attaching a variant with a Suggested-by for Vladimir
> > > > to properly credit the patch origin.
> > > >
> > > > Let me know if that works. I changed it slightly and only casting to
> > > > long long, and made it almost checkpatch clean.
> > >
> > > I suppose strftime(3) might be nicer, but this works.
> > >
> > > Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
> >
> > I noticed this is not yet applied to the repository, do you need
> > anything else from me or did it just felt trouch the cracks or
> > actually queued?
> >
> > Asking since if you want to have it done differently I will then
> > follow suit downstream as well in Debian, where we have for now
> > applied the submitted patch.
>
> Salvatore, can you resend the patch inline (not as an attachment)
> To: Steve, Cc: linux-nfs@ ?
Yes sure, sorry about it. Here it is submitted:
https://lore.kernel.org/linux-nfs/20240502135320.3445429-1-carnil@debian.org/T/#u
Regards,
Salvatore
prev parent reply other threads:[~2024-05-02 13:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-06 19:15 Fails to build on arm{el,hf} with 64bit time_t: export-cache.c:110:51: error: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘time_t’ {aka ‘long long int’} [-Werror=format=] Salvatore Bonaccorso
2024-04-06 19:28 ` Chuck Lever III
2024-05-02 5:00 ` Salvatore Bonaccorso
2024-05-02 12:57 ` Chuck Lever
2024-05-02 13:55 ` Salvatore Bonaccorso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjObVI2tISaGfIcv@eldamar.lan \
--to=carnil@debian.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).