From: Chuck Lever <chuck.lever@oracle.com>
To: NeilBrown <neilb@suse.de>
Cc: Jeff Layton <jlayton@kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
Olga Kornievskaia <kolga@netapp.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Subject: Re: [PATCH 0/4 v4] nfsd: fix deadlock in move_to_close_lru()
Date: Mon, 8 Apr 2024 22:09:27 -0400 [thread overview]
Message-ID: <ZhSjVyrdTyqyj1Hy@tissot.1015granger.net> (raw)
In-Reply-To: <20240408021156.6104-1-neilb@suse.de>
On Sun, Apr 07, 2024 at 10:09:14PM -0400, NeilBrown wrote:
> This series replaces
> nfsd: drop st_mutex and rp_mutex before calling move_to_close_lru()
> which was recently dropped as a problem was found.
> The first two patches rearrange code without important functional change.
> The last two address the two relaced problems of two different mutexes which are
> held while waiting and can each trigger a deadlock.
>
> This is against v6.9-rc2.
>
> Thanks,
> NeilBrown
>
> [PATCH 1/4] nfsd: perform all find_openstateowner_str calls in the
> [PATCH 2/4] nfsd: move nfsd4_cstate_assign_replay() earlier in open
> [PATCH 3/4] nfsd: replace rp_mutex to avoid deadlock in
> [PATCH 4/4] nfsd: drop st_mutex before calling move_to_close_lru()
Applied to nfsd-next. Thank you, Neil!
--
Chuck Lever
prev parent reply other threads:[~2024-04-09 2:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 2:09 [PATCH 0/4 v4] nfsd: fix deadlock in move_to_close_lru() NeilBrown
2024-04-08 2:09 ` [PATCH 1/4] nfsd: perform all find_openstateowner_str calls in the one place NeilBrown
2024-04-08 2:09 ` [PATCH 2/4] nfsd: move nfsd4_cstate_assign_replay() earlier in open handling NeilBrown
2024-04-08 2:09 ` [PATCH 3/4] nfsd: replace rp_mutex to avoid deadlock in move_to_close_lru() NeilBrown
2024-04-08 2:09 ` [PATCH 4/4] nfsd: drop st_mutex before calling move_to_close_lru() NeilBrown
2024-04-09 2:09 ` Chuck Lever [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhSjVyrdTyqyj1Hy@tissot.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=kolga@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).