From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Cc: Petr Vorel <pvorel@suse.cz>, NeilBrown <neilb@suse.de>,
Cyril Hrubis <chrubis@suse.cz>,
Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>,
linux-nfs@vger.kernel.org
Subject: [PATCH 1/1] proc01: Whitelist /proc/fs/nfsd/nfsv4recoverydir
Date: Mon, 15 Apr 2024 19:21:33 +0200 [thread overview]
Message-ID: <20240415172133.553441-1-pvorel@suse.cz> (raw)
/proc/fs/nfsd/nfsv4recoverydir started from kernel 6.8 report EINVAL.
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Hi,
@ Jeff, Chuck, Neil, NFS devs: The patch itself whitelist reading
/proc/fs/nfsd/nfsv4recoverydir in LTP test. I suspect reading failed
with EINVAL in 6.8 was a deliberate change and expected behavior when
CONFIG_NFSD_LEGACY_CLIENT_TRACKING is not set:
$ sudo cat /proc/fs/nfsd/nfsv4recoverydir
cat: /proc/fs/nfsd/nfsv4recoverydir: Invalid argument
I'm asking because It worked fine in kernel 6.7:
$ sudo cat /proc/fs/nfsd/nfsv4recoverydir
/var/lib/nfs/v4recovery
I did not bisect but I suspect suspect 74fd48739d04 ("nfsd: new Kconfig
option for legacy client tracking") from v6.8-rc1. The system I test
(openSUSE Tumbleweed) has not CONFIG_NFSD_LEGACY_CLIENT_TRACKING set and
74fd48739d04 wraps write_recoverydir setup, thus it's not set.
+#ifdef CONFIG_NFSD_LEGACY_CLIENT_TRACKING
[NFSD_RecoveryDir] = write_recoverydir,
+#endif
Kind regards,
Petr
testcases/kernel/fs/proc/proc01.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/testcases/kernel/fs/proc/proc01.c b/testcases/kernel/fs/proc/proc01.c
index c90e509a3..08b9bbc75 100644
--- a/testcases/kernel/fs/proc/proc01.c
+++ b/testcases/kernel/fs/proc/proc01.c
@@ -113,6 +113,7 @@ static const struct mapping known_issues[] = {
{"read", "/proc/fs/nfsd/filehandle", EINVAL},
{"read", "/proc/fs/nfsd/.getfs", EINVAL},
{"read", "/proc/fs/nfsd/.getfd", EINVAL},
+ {"read", "/proc/fs/nfsd/nfsv4recoverydir", EINVAL},
{"read", "/proc/self/net/rpc/use-gss-proxy", EAGAIN},
{"read", "/proc/sys/net/ipv6/conf/*/stable_secret", EIO},
{"read", "/proc/sys/vm/nr_hugepages", EOPNOTSUPP},
--
2.43.0
next reply other threads:[~2024-04-15 17:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 17:21 Petr Vorel [this message]
2024-04-15 17:27 ` [PATCH 1/1] proc01: Whitelist /proc/fs/nfsd/nfsv4recoverydir Chuck Lever III
2024-04-15 17:35 ` Jeff Layton
2024-04-15 17:37 ` Chuck Lever III
2024-04-15 17:43 ` Jeff Layton
2024-04-15 18:00 ` Petr Vorel
2024-04-15 21:07 ` Chuck Lever
2024-04-15 23:52 ` NeilBrown
2024-04-16 10:10 ` Jeff Layton
2024-04-16 18:50 ` Chuck Lever
2024-04-17 6:06 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240415172133.553441-1-pvorel@suse.cz \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).