From: Jeff Layton <jlayton@kernel.org>
To: trondmy@gmail.com, Steve Dickson <SteveD@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2] nfsd: allow more than 64 backlogged connections
Date: Fri, 08 Mar 2024 13:48:14 -0500 [thread overview]
Message-ID: <0a0345f5c0e14e67541172059cc39ebe389126e5.camel@kernel.org> (raw)
In-Reply-To: <20240308180223.2965601-1-trond.myklebust@hammerspace.com>
On Fri, 2024-03-08 at 13:02 -0500, trondmy@gmail.com wrote:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
>
> When creating a listener socket to be handed to /proc/fs/nfsd/portlist,
> we currently limit the number of backlogged connections to 64. Since
> that value was chosen in 2006, the scale at which data centres operate
> has changed significantly. Given a modern server with many thousands of
> clients, a limit of 64 connections can create bottlenecks, particularly
> at at boot time.
> Let's use the POSIX-sanctioned maximum value of SOMAXCONN.
>
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> ---
> v2: Use SOMAXCONN instead of a value of -1.
>
> utils/nfsd/nfssvc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/utils/nfsd/nfssvc.c b/utils/nfsd/nfssvc.c
> index 46452d972407..9650cecee986 100644
> --- a/utils/nfsd/nfssvc.c
> +++ b/utils/nfsd/nfssvc.c
> @@ -205,7 +205,8 @@ nfssvc_setfds(const struct addrinfo *hints, const char *node, const char *port)
> rc = errno;
> goto error;
> }
> - if (addr->ai_protocol == IPPROTO_TCP && listen(sockfd, 64)) {
> + if (addr->ai_protocol == IPPROTO_TCP &&
> + listen(sockfd, SOMAXCONN)) {
> xlog(L_ERROR, "unable to create listening socket: "
> "errno %d (%m)", errno);
> rc = errno;
Reviewed-by: Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2024-03-08 18:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 18:02 [PATCH v2] nfsd: allow more than 64 backlogged connections trondmy
2024-03-08 18:48 ` Jeff Layton [this message]
2024-03-08 18:56 ` Chuck Lever
2024-03-11 7:55 ` Cedric Blancher
2024-04-11 19:11 ` Trond Myklebust
2024-04-12 1:56 ` Hanxiao Chen (Fujitsu)
2024-05-09 13:31 ` Jeff Layton
2024-05-10 11:27 ` Steve Dickson
2024-05-10 13:18 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a0345f5c0e14e67541172059cc39ebe389126e5.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=SteveD@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).