From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-nfc@lists.01.org, devicetree@vger.kernel.org,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Charles Gorand <charles.gorand@effinnov.com>
Subject: [linux-nfc] Re: [PATCH 1/7] dt-bindings: nfc: nxp,nci: convert to dtschema
Date: Sun, 10 Oct 2021 22:58:59 +0200 [thread overview]
Message-ID: <f955726a-eb2d-7b3e-9c5f-978358710eb6@canonical.com> (raw)
In-Reply-To: <1633894316.441793.3158669.nullmailer@robh.at.kernel.org>
On 10/10/2021 21:31, Rob Herring wrote:
> On Sun, 10 Oct 2021 16:23:11 +0200, Krzysztof Kozlowski wrote:
>> Convert the NXP NCI NFC controller to DT schema format.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>> ---
>> .../devicetree/bindings/net/nfc/nxp,nci.yaml | 61 +++++++++++++++++++
>> .../devicetree/bindings/net/nfc/nxp-nci.txt | 33 ----------
>> MAINTAINERS | 1 +
>> 3 files changed, 62 insertions(+), 33 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
>> delete mode 100644 Documentation/devicetree/bindings/net/nfc/nxp-nci.txt
>>
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/1539010
>
>
> nfc@28: 'clock-frequency' is a required property
> arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml
>
Hmm, this actually looks as mistake in bindings. First, clock-frequency
is a property of a I2C bus, not I2C child device. Second, it should not
be a required property anyway, as I2C will choose a default one matching
driver (e.g. standard speed of 100 kHz).
Except the trf7970a NFC driver, none of other NFC drivers parse the
clock-frequency.
Best regards,
Krzysztof
_______________________________________________
Linux-nfc mailing list -- linux-nfc@lists.01.org
To unsubscribe send an email to linux-nfc-leave@lists.01.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
prev parent reply other threads:[~2021-10-10 20:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-10 14:23 [linux-nfc] [PATCH 1/7] dt-bindings: nfc: nxp,nci: convert to dtschema Krzysztof Kozlowski
2021-10-10 14:23 ` [linux-nfc] [PATCH 2/7] dt-bindings: nfc: nxp,pn532: " Krzysztof Kozlowski
2021-10-10 14:23 ` [linux-nfc] [PATCH 3/7] dt-bindings: nfc: st,st21nfca: " Krzysztof Kozlowski
2021-10-10 14:23 ` [linux-nfc] [PATCH 4/7] dt-bindings: nfc: st,st95hf: " Krzysztof Kozlowski
2021-10-10 14:23 ` [linux-nfc] [PATCH 5/7] dt-bindings: nfc: st,nci: " Krzysztof Kozlowski
2021-10-10 14:23 ` [linux-nfc] [PATCH 6/7] dt-bindings: nfc: ti,trf7970a: " Krzysztof Kozlowski
[not found] ` <1633894316.452946.3158671.nullmailer@robh.at.kernel.org>
2021-10-10 20:51 ` [linux-nfc] " Krzysztof Kozlowski
2021-10-10 14:23 ` [linux-nfc] [PATCH 7/7] dt-bindings: nfc: marvell,nfc: " Krzysztof Kozlowski
[not found] ` <1633894316.441793.3158669.nullmailer@robh.at.kernel.org>
2021-10-10 20:52 ` [linux-nfc] Re: [PATCH 1/7] dt-bindings: nfc: nxp,nci: " Krzysztof Kozlowski
2021-10-10 20:58 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f955726a-eb2d-7b3e-9c5f-978358710eb6@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=charles.gorand@effinnov.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).