From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: linux-nfc@lists.01.org
Cc: Mark Greer <mgreer@animalcreek.com>
Subject: [linux-nfc] Re: [neard][PATCH] Revert "include: Add a copy of the NFC kernel header"
Date: Mon, 14 Feb 2022 13:32:32 +0100 [thread overview]
Message-ID: <c976051a-54ee-a96f-06d7-3ec3ccc4d360@canonical.com> (raw)
In-Reply-To: <20220214123110.27056-2-krzysztof.kozlowski@canonical.com>
On 14/02/2022 13:31, Krzysztof Kozlowski wrote:
> This reverts commit fb7664e2995f2b5bed4b93c7c82aab14c2485eb8 and changes
> several other files to match the scope of revert (using back system
> header, instead of local copy).
>
> The reverted commit argued it is better to miss header updates than not
> being able to run the neard daemon at all. It's not correct. The
> /usr/include/linux/nfc.h header does not affect the runnability of
> daemon but the build stage. The daemon, once compiled, will be able to
> run even if nfc.h system header changes.
>
> However in case of any important differences in nfc.h, it is better to
> fail early during build time, than later during runtime because of
> differences of ABI (structures or functions) between kernel and
> user-space.
>
> Rely back on system/kernel header, to avoid manual synchronisation.
> This will also force us to keep the neard updated if kernel header
> changes.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
This was sent by mistake, please ignore.
Best regards,
Krzysztof
_______________________________________________
Linux-nfc mailing list -- linux-nfc@lists.01.org
To unsubscribe send an email to linux-nfc-leave@lists.01.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
next prev parent reply other threads:[~2022-02-14 12:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 12:31 [linux-nfc] [neard][PATCH 1/3] ci: show kernel headers version and difference against embedded nfc.h Krzysztof Kozlowski
2022-02-14 12:31 ` [linux-nfc] [neard][PATCH] Revert "include: Add a copy of the NFC kernel header" Krzysztof Kozlowski
2022-02-14 12:32 ` Krzysztof Kozlowski [this message]
2022-02-14 12:31 ` [linux-nfc] [neard][PATCH 2/3] ci: build on newer Fedora Linux (34 and 35) Krzysztof Kozlowski
2022-02-14 12:31 ` [linux-nfc] [neard][PATCH 3/3] include: sync nfc_copy.h with Linux kernel v5.17-rc4 Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c976051a-54ee-a96f-06d7-3ec3ccc4d360@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=linux-nfc@lists.01.org \
--cc=mgreer@animalcreek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).