From: Martin Faltesek <mfaltesek@google.com>
To: Denis Efremov <denis.e.efremov@oracle.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
christophe.ricard@gmail.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <groeck@google.com>,
jordy@pwning.systems, krzk@kernel.org,
Martin Faltesek <martin.faltesek@gmail.com>,
netdev@vger.kernel.org, linux-nfc@lists.01.org,
William K Lin <wklin@google.com>,
theflamefire89@gmail.com
Subject: [linux-nfc] Re: [PATCH net v3 0/3] Split "nfc: st21nfca: Refactor EVT_TRANSACTION" into 3
Date: Wed, 20 Jul 2022 08:53:44 -0600 [thread overview]
Message-ID: <CAOiWkA_AcD_J1r1ncvmX8YswbMiS2fx5WySrYwvfdFE4qgk=hQ@mail.gmail.com> (raw)
In-Reply-To: <fc85ff14-70d6-0c3e-247d-eda2284a5f6b@oracle.com>
On Wed, Jul 20, 2022 at 1:25 AM Denis Efremov
<denis.e.efremov@oracle.com> wrote:
>
> Hi,
>
> On 6/7/22 06:57, Martin Faltesek wrote:
> >
> > Martin Faltesek (3):
> > nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION
> > nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling
> > nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION
> >
> > drivers/nfc/st21nfca/se.c | 53 ++++++++++++++++++++++-----------------
> > 1 file changed, 30 insertions(+), 23 deletions(-)
>
>
> It looks like driver st-nci contains the same problems and all 3 fixes are
> also applicable to st_nci_hci_connectivity_event_received() function.
> At least I can see the memory leak
> https://elixir.bootlin.com/linux/v5.19-rc7/source/drivers/nfc/st-nci/se.c#L343
>
> Can you please double check the st-nci driver and send the same fixes to it?
> Reported-by: Denis Efremov <denis.e.efremov@oracle.com>
Will do.
_______________________________________________
Linux-nfc mailing list -- linux-nfc@lists.01.org
To unsubscribe send an email to linux-nfc-leave@lists.01.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
prev parent reply other threads:[~2022-07-20 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220607025729.1673212-1-mfaltesek@google.com>
[not found] ` <20220607025729.1673212-2-mfaltesek@google.com>
2022-06-07 17:13 ` [linux-nfc] Re: [PATCH net v3 1/3] nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION Krzysztof Kozlowski
[not found] ` <20220607025729.1673212-3-mfaltesek@google.com>
2022-06-07 17:15 ` [linux-nfc] Re: [PATCH net v3 2/3] nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling Krzysztof Kozlowski
[not found] ` <20220607025729.1673212-4-mfaltesek@google.com>
2022-06-08 7:09 ` [linux-nfc] Re: [PATCH net v3 3/3] nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION Krzysztof Kozlowski
[not found] ` <fc85ff14-70d6-0c3e-247d-eda2284a5f6b@oracle.com>
2022-07-20 14:53 ` Martin Faltesek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOiWkA_AcD_J1r1ncvmX8YswbMiS2fx5WySrYwvfdFE4qgk=hQ@mail.gmail.com' \
--to=mfaltesek@google.com \
--cc=christophe.ricard@gmail.com \
--cc=denis.e.efremov@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@google.com \
--cc=jordy@pwning.systems \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=martin.faltesek@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=theflamefire89@gmail.com \
--cc=wklin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).