From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Kent Overstreet <kent.overstreet@linux.dev>,
Suren Baghdasaryan <surenb@google.com>,
Bingbu Cao <bingbu.cao@intel.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: build failure after merge of the v4l-dvb-next tree
Date: Mon, 6 May 2024 10:49:53 +1000 [thread overview]
Message-ID: <20240506104953.49666125@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 2331 bytes --]
Hi all,
After merging the v4l-dvb-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/media/pci/intel/ipu6/ipu6-mmu.c: In function 'ipu6_mmu_alloc':
drivers/media/pci/intel/ipu6/ipu6-mmu.c:541:28: error: implicit declaration of function 'vzalloc'; did you mean 'kzalloc'? [-Werror=implicit-function-declaration]
541 | mmu_info->l2_pts = vzalloc(ISP_L2PT_PTES * sizeof(*mmu_info->l2_pts));
| ^~~~~~~
| kzalloc
drivers/media/pci/intel/ipu6/ipu6-mmu.c:541:26: error: assignment to 'u32 **' {aka 'unsigned int **'} from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
541 | mmu_info->l2_pts = vzalloc(ISP_L2PT_PTES * sizeof(*mmu_info->l2_pts));
| ^
drivers/media/pci/intel/ipu6/ipu6-mmu.c:560:9: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
560 | vfree(mmu_info->l2_pts);
| ^~~~~
| kvfree
cc1: all warnings being treated as errors
Caused by commit
9163d83573e4 ("media: intel/ipu6: add IPU6 DMA mapping API and MMU table")
not including <linux/vmalloc.h>. It may have been exposed by commit
690da22dbfa8 ("asm-generic/io.h: kill vmalloc.h dependency")
from the mm-unstable branch of the mm tree, so I have applied the
following patch for today (and this or somthing like it should be applied
to the v4l-dvb-next tree).
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 6 May 2024 10:39:47 +1000
Subject: [PATCH] media: intel/ipu6: explicitly include vmalloc.h
since this file uses vzalloc etc ...
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/media/pci/intel/ipu6/ipu6-mmu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/pci/intel/ipu6/ipu6-mmu.c b/drivers/media/pci/intel/ipu6/ipu6-mmu.c
index 98a4bf9ca267..c3a20507d6db 100644
--- a/drivers/media/pci/intel/ipu6/ipu6-mmu.c
+++ b/drivers/media/pci/intel/ipu6/ipu6-mmu.c
@@ -22,6 +22,7 @@
#include <linux/slab.h>
#include <linux/spinlock.h>
#include <linux/types.h>
+#include <linux/vmalloc.h>
#include "ipu6.h"
#include "ipu6-dma.h"
--
2.43.0
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2024-05-06 0:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 0:49 Stephen Rothwell [this message]
2024-05-07 11:56 ` linux-next: build failure after merge of the v4l-dvb-next tree Sakari Ailus
2024-05-07 12:32 ` [PATCH v2 1/1] media: intel/ipu6: explicitly include vmalloc.h Sakari Ailus
2024-05-07 12:35 ` [RESEND PATCH " Sakari Ailus
-- strict thread matches above, loose matches on Subject: below --
2024-05-01 0:22 linux-next: build failure after merge of the v4l-dvb-next tree Stephen Rothwell
2023-10-09 0:08 Stephen Rothwell
2023-10-09 9:25 ` Bryan O'Donoghue
2023-10-09 9:50 ` Hans Verkuil
2021-09-20 0:19 Stephen Rothwell
2021-09-20 7:39 ` Sean Young
2021-05-19 23:55 Stephen Rothwell
2020-06-03 2:46 Stephen Rothwell
2020-06-03 8:13 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240506104953.49666125@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=bingbu.cao@intel.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kent.overstreet@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).