From: Zhihao Cheng <chengzhihao1@huawei.com>
To: Arnd Bergmann <arnd@kernel.org>,
Richard Weinberger <richard@nod.at>,
Arnd Bergmann <arnd@arndb.de>
Cc: kernel test robot <lkp@intel.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ubifs: fix function comment warning
Date: Tue, 27 Feb 2024 10:47:04 +0800 [thread overview]
Message-ID: <e10d1819-bd02-ad1a-444d-bf77b3a9a369@huawei.com> (raw)
In-Reply-To: <20240226121600.1267204-1-arnd@kernel.org>
在 2024/2/26 20:15, Arnd Bergmann 写道:
> From: Arnd Bergmann <arnd@arndb.de>
>
> My previous fix introduced a new W=1 warning for the kerneldoc style
> comments:
>
> fs/ubifs/find.c:86: warning: Function parameter or struct member 'arg' not described in 'scan_for_dirty_cb'
>
> Adjust the comments to the argument names.
>
> Reported-by: Zhihao Cheng <chengzhihao1@huawei.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202402261559.cYtMOkIn-lkp@intel.com/
> Fixes: ec724e534dfd ("ubifs: fix function pointer cast warnings")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> fs/ubifs/find.c | 8 ++++----
> fs/ubifs/lprops.c | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
The commit title could be more detailed(eg. add function name) in next time.
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
> diff --git a/fs/ubifs/find.c b/fs/ubifs/find.c
> index 6ebf3c04ac5f..643718906b9f 100644
> --- a/fs/ubifs/find.c
> +++ b/fs/ubifs/find.c
> @@ -73,7 +73,7 @@ static int valuable(struct ubifs_info *c, const struct ubifs_lprops *lprops)
> * @c: the UBIFS file-system description object
> * @lprops: LEB properties to scan
> * @in_tree: whether the LEB properties are in main memory
> - * @data: information passed to and from the caller of the scan
> + * @arg: information passed to and from the caller of the scan
> *
> * This function returns a code that indicates whether the scan should continue
> * (%LPT_SCAN_CONTINUE), whether the LEB properties should be added to the tree
> @@ -340,7 +340,7 @@ int ubifs_find_dirty_leb(struct ubifs_info *c, struct ubifs_lprops *ret_lp,
> * @c: the UBIFS file-system description object
> * @lprops: LEB properties to scan
> * @in_tree: whether the LEB properties are in main memory
> - * @data: information passed to and from the caller of the scan
> + * @arg: information passed to and from the caller of the scan
> *
> * This function returns a code that indicates whether the scan should continue
> * (%LPT_SCAN_CONTINUE), whether the LEB properties should be added to the tree
> @@ -581,7 +581,7 @@ int ubifs_find_free_space(struct ubifs_info *c, int min_space, int *offs,
> * @c: the UBIFS file-system description object
> * @lprops: LEB properties to scan
> * @in_tree: whether the LEB properties are in main memory
> - * @data: information passed to and from the caller of the scan
> + * @arg: information passed to and from the caller of the scan
> *
> * This function returns a code that indicates whether the scan should continue
> * (%LPT_SCAN_CONTINUE), whether the LEB properties should be added to the tree
> @@ -773,7 +773,7 @@ int ubifs_save_dirty_idx_lnums(struct ubifs_info *c)
> * @c: the UBIFS file-system description object
> * @lprops: LEB properties to scan
> * @in_tree: whether the LEB properties are in main memory
> - * @data: information passed to and from the caller of the scan
> + * @arg: information passed to and from the caller of the scan
> *
> * This function returns a code that indicates whether the scan should continue
> * (%LPT_SCAN_CONTINUE), whether the LEB properties should be added to the tree
> diff --git a/fs/ubifs/lprops.c b/fs/ubifs/lprops.c
> index a11c3dab7e16..8788740ec57f 100644
> --- a/fs/ubifs/lprops.c
> +++ b/fs/ubifs/lprops.c
> @@ -1005,7 +1005,7 @@ void dbg_check_heap(struct ubifs_info *c, struct ubifs_lpt_heap *heap, int cat,
> * @c: the UBIFS file-system description object
> * @lp: LEB properties to scan
> * @in_tree: whether the LEB properties are in main memory
> - * @lst: lprops statistics to update
> + * @arg: lprops statistics to update
> *
> * This function returns a code that indicates whether the scan should continue
> * (%LPT_SCAN_CONTINUE), whether the LEB properties should be added to the tree
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2024-02-27 2:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 12:15 [PATCH] ubifs: fix function comment warning Arnd Bergmann
2024-02-27 2:47 ` Zhihao Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e10d1819-bd02-ad1a-444d-bf77b3a9a369@huawei.com \
--to=chengzhihao1@huawei.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=lkp@intel.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).