From: <Balamanikandan.Gunasundar@microchip.com>
To: <Conor.Dooley@microchip.com>
Cc: <conor@kernel.org>, <miquel.raynal@bootlin.com>, <richard@nod.at>,
<vigneshr@ti.com>, <robh@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<claudiu.beznea@tuxon.dev>, <linux-mtd@lists.infradead.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: mtd: atmel-nand: convert txt to yaml
Date: Mon, 25 Mar 2024 03:56:46 +0000 [thread overview]
Message-ID: <d3f2c773-ca53-43bd-bca8-4e27b9a4e5c1@microchip.com> (raw)
In-Reply-To: <20240322-arrest-pucker-7ff731359fa0@wendy>
On 22/03/24 1:00 pm, Conor Dooley wrote:
> On Fri, Mar 22, 2024 at 04:27:29AM +0000, Balamanikandan.Gunasundar@microchip.com wrote:
>> On 20/03/24 10:05 pm, Conor Dooley wrote:
>>> On Wed, Mar 20, 2024 at 11:22:07AM +0530, Balamanikandan Gunasundar wrote:
>
>>>> +allOf:
>>>> + - if:
>>>> + properties:
>>>> + compatible:
>>>> + contains:
>>>> + enum:
>>>> + - atmel,at91rm9200-nand-controller
>>>> + - atmel,at91sam9260-nand-controller
>>>> + - atmel,at91sam9261-nand-controller
>>>> + - atmel,at91sam9g45-nand-controller
>>>> + - atmel,sama5d3-nand-controller
>>>> + - microchip,sam9x60-nand-controller
>>>> + then:
>>>> + properties:
>>>> + "#address-cells":
>>>> + const: 2
>>>> +
>>>> + "#size-cells":
>>>> + const: 1
>>> Why is this in an if? Isn't this all of the devices in the binding?
>>>
>>
>> The default nand-controller.yaml defines this as const values.
>> (#address-cell : 1 and #size-cells : 1). I am trying to override this
>> const value.
>
> You're not overriding anything as you don't have a ref to
> nand-controller.yaml in this file, AFAICT. Why don't you?
>
>> May be I should think about better approach ?
>
> You should be able to apply this unconditionally for this file. I don't
> see why the if would be needed?
>
>
>>>> +patternProperties:
>>>> + "^nand@[a-f0-9]$":
>>>> + type: object
>>>> + $ref: nand-chip.yaml#
>>>> + description:
>>>> + NAND chip bindings. All generic properties described in
>>>> + Documentation/devicetree/bindings/mtd/{common,nand}.txt also apply to
>>>> + the NAND device node, and NAND partitions should be defined under the
>>>> + NAND node as described in
>>>> + Documentation/devicetree/bindings/mtd/partition.txt.
>>> These files do not exist.
>>>
>>
>> Apologies for copying the content from the text file. I will correct this.
>
> You don't need these comments at all I think. You have the ref to
> nand-chip.yaml, so at least the first text file reference can be
> removed.
>
Agree with this. I will remove it.
>> Yes. I should fix the alignment. I will send a v2 shortly
>
> I did make other comments, so I assume you agree with everything else I
> mentioned and will implement them in v2.
Yes. I agree with other comments as well. I will also address all the
comments with the other 2 patches and send a v2. Thanks for reviewing.
Regards,
Bala.
>
> Thanks,
> Conor.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2024-03-25 3:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 5:52 [PATCH 0/3] dt-bindings: mtd: atmel-nand: convert txt to yaml Balamanikandan Gunasundar
2024-03-20 5:52 ` [PATCH 1/3] " Balamanikandan Gunasundar
2024-03-20 16:35 ` Conor Dooley
2024-03-22 4:27 ` Balamanikandan.Gunasundar
2024-03-22 7:30 ` Conor Dooley
2024-03-25 3:56 ` Balamanikandan.Gunasundar [this message]
2024-03-20 5:52 ` [PATCH 2/3] dt-bindings: mtd: atmel-nand: add atmel pmecc Balamanikandan Gunasundar
2024-03-20 16:40 ` Conor Dooley
2024-03-20 5:52 ` [PATCH 3/3] dt-bindings: mtd: atmel-nand: add deprecated bindings Balamanikandan Gunasundar
2024-03-20 16:25 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3f2c773-ca53-43bd-bca8-4e27b9a4e5c1@microchip.com \
--to=balamanikandan.gunasundar@microchip.com \
--cc=Conor.Dooley@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).